-
Notifications
You must be signed in to change notification settings - Fork 440
Only add Ampq transport factories when packages are found #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
AmqpTransportFactory is in |
But the
Should I always require |
You shouldn't, the bundle heavily rely on it and hence require it itself |
Are there any errors you face? |
The DelayStrategyTransportFactoryTrait is from the ampq-tools package. Which isn't a requirement for enqueue/enqueue nor for the enqueue-bundle. Or am I missing something? I get an error that the Trait can't be found. Since the bundle tries to load the |
Okay, let's merge this then. Could you please CS issues please? |
This is the correct check to avoid adding the TransportFactories? |
yeap |
Commit contains better fix for this issue 031380e. I kept both changes for now, though ones you added are not needed any more |
Only add Ampq transport factories when packages are found
No description provided.