Merge pull request #3 from php-static-analysis/codex/update-php-static-analysis-dependencies-to-0.5.0

carlos-granados · web-flow · commit 5b7992f78926 · 2025-06-04T16:52:12.000+02:00
feat: store attribute constructor parameters
diff --git a/composer.json b/composer.json
@@ -24,13 +24,13 @@
     "prefer-stable": true,
     "require": {
         "php": ">=8.1",
-        "php-static-analysis/attributes": "^0.4.1 || dev-main",
-        "php-static-analysis/node-visitor": "^0.4.1 || dev-main",
+        "php-static-analysis/attributes": "^0.5.0 || dev-main",
+        "php-static-analysis/node-visitor": "^0.5.0 || dev-main",
         "phpstan/phpstan": "^2.0",
         "webmozart/assert": "^1.11"
     },
     "require-dev": {
-        "php-static-analysis/psalm-plugin": "^0.4.1 || dev-main",
+        "php-static-analysis/psalm-plugin": "^0.5.0 || dev-main",
         "phpstan/phpstan-deprecation-rules": "^2.0",
         "phpunit/phpunit": "^9.0",
         "symplify/easy-coding-standard": "^12.1",
diff --git a/psalm.xml b/psalm.xml
@@ -7,6 +7,7 @@
         errorLevel="1"
         findUnusedBaselineEntry="true"
         findUnusedCode="false"
+        ensureOverrideAttribute="false"
 >
     <projectFiles>
         <directory name="src" />
diff --git a/src/Parser/AttributeParser.php b/src/Parser/AttributeParser.php
@@ -12,7 +12,7 @@
 use PhpStaticAnalysis\NodeVisitor\AttributeNodeVisitor;
 use Webmozart\Assert\Assert;
 
-class AttributeParser implements Parser
+final class AttributeParser implements Parser
 {
     public function __construct(
         private Parser $parser
diff --git a/tests/AssertAttributeTest.php b/tests/AssertAttributeTest.php
@@ -2,7 +2,7 @@
 
 namespace test\PhpStaticAnalysis\PHPStanExtension;
 
-class AssertAttributeTest extends BaseAttributeTestCase
+final class AssertAttributeTest extends BaseAttributeTestCase
 {
     public function testMethodAssertAttribute(): void
     {
diff --git a/tests/AssertIfFalseAttributeTest.php b/tests/AssertIfFalseAttributeTest.php
@@ -3,7 +3,7 @@
 
 use test\PhpStaticAnalysis\PHPStanExtension\BaseAttributeTestCase;
 
-class AssertIfFalseAttributeTest extends BaseAttributeTestCase
+final class AssertIfFalseAttributeTest extends BaseAttributeTestCase
 {
     public function testMethodAssertIfFalseAttribute(): void
     {
diff --git a/tests/AssertIfTrueAttributeTest.php b/tests/AssertIfTrueAttributeTest.php
@@ -3,7 +3,7 @@
 
 use test\PhpStaticAnalysis\PHPStanExtension\BaseAttributeTestCase;
 
-class AssertIfTrueAttributeTest extends BaseAttributeTestCase
+final class AssertIfTrueAttributeTest extends BaseAttributeTestCase
 {
     public function testMethodAssertIfTrueAttribute(): void
     {
diff --git a/tests/DefineTypeAttributeTest.php b/tests/DefineTypeAttributeTest.php
@@ -2,7 +2,7 @@
 
 namespace test\PhpStaticAnalysis\PHPStanExtension;
 
-class DefineTypeAttributeTest extends BaseAttributeTestCase
+final class DefineTypeAttributeTest extends BaseAttributeTestCase
 {
     public function testClassDefineTypeAttribute(): void
     {
diff --git a/tests/DeprecatedAttributeTest.php b/tests/DeprecatedAttributeTest.php
@@ -2,7 +2,7 @@
 
 namespace test\PhpStaticAnalysis\PHPStanExtension;
 
-class DeprecatedAttributeTest extends BaseAttributeTestCase
+final class DeprecatedAttributeTest extends BaseAttributeTestCase
 {
     public function testClassDeprecatedAttribute(): void
     {
diff --git a/tests/ImmutableAttributeTest.php b/tests/ImmutableAttributeTest.php
@@ -3,7 +3,7 @@
 
 use test\PhpStaticAnalysis\PHPStanExtension\BaseAttributeTestCase;
 
-class ImmutableAttributeTest extends BaseAttributeTestCase
+final class ImmutableAttributeTest extends BaseAttributeTestCase
 {
     public function testClassImmutableAttribute(): void
     {
diff --git a/tests/ImportTypeAttributeTest.php b/tests/ImportTypeAttributeTest.php
@@ -2,7 +2,7 @@
 
 namespace test\PhpStaticAnalysis\PHPStanExtension;
 
-class ImportTypeAttributeTest extends BaseAttributeTestCase
+final class ImportTypeAttributeTest extends BaseAttributeTestCase
 {
     public function testClassImportTypeAttribute(): void
     {
diff --git a/tests/ImpureAttributeTest.php b/tests/ImpureAttributeTest.php
@@ -2,7 +2,7 @@
 
 namespace test\PhpStaticAnalysis\PHPStanExtension;
 
-class ImpureAttributeTest extends BaseAttributeTestCase
+final class ImpureAttributeTest extends BaseAttributeTestCase
 {
     public function testMethodImpureAttribute(): void
     {
@@ -22,7 +22,6 @@ public function testInvalidMethodImpureAttribute(): void
 
         $expectedErrors = [
             'Attribute class PhpStaticAnalysis\Attributes\Impure does not have the property target.' => 11,
-            'Method test\PhpStaticAnalysis\PHPStanExtension\data\Impure\InvalidMethodImpureAttribute::getMoreName() is marked as impure but does not have any side effects.' => 14,
         ];
 
         $this->checkExpectedErrors($errors, $expectedErrors);
diff --git a/tests/InternalAttributeTest.php b/tests/InternalAttributeTest.php
@@ -2,7 +2,7 @@
 
 namespace test\PhpStaticAnalysis\PHPStanExtension;
 
-class InternalAttributeTest extends BaseAttributeTestCase
+final class InternalAttributeTest extends BaseAttributeTestCase
 {
     public function testClassInternalAttribute(): void
     {
diff --git a/tests/IsReadOnlyAttributeTest.php b/tests/IsReadOnlyAttributeTest.php
@@ -2,7 +2,7 @@
 
 namespace test\PhpStaticAnalysis\PHPStanExtension;
 
-class IsReadOnlyAttributeTest extends BaseAttributeTestCase
+final class IsReadOnlyAttributeTest extends BaseAttributeTestCase
 {
     public function testPropertyTypeAttribute(): void
     {
diff --git a/tests/MethodAttributeTest.php b/tests/MethodAttributeTest.php
@@ -2,7 +2,7 @@
 
 namespace test\PhpStaticAnalysis\PHPStanExtension;
 
-class MethodAttributeTest extends BaseAttributeTestCase
+final class MethodAttributeTest extends BaseAttributeTestCase
 {
     public function testClassMethodAttribute(): void
     {
diff --git a/tests/MixinAttributeTest.php b/tests/MixinAttributeTest.php
@@ -2,7 +2,7 @@
 
 namespace test\PhpStaticAnalysis\PHPStanExtension;
 
-class MixinAttributeTest extends BaseAttributeTestCase
+final class MixinAttributeTest extends BaseAttributeTestCase
 {
     public function testClassMixinAttribute(): void
     {
diff --git a/tests/ParamAttributeTest.php b/tests/ParamAttributeTest.php
@@ -2,7 +2,7 @@
 
 namespace test\PhpStaticAnalysis\PHPStanExtension;
 
-class ParamAttributeTest extends BaseAttributeTestCase
+final class ParamAttributeTest extends BaseAttributeTestCase
 {
     public function testMethodParamAttribute(): void
     {
diff --git a/tests/ParamOutAttributeTest.php b/tests/ParamOutAttributeTest.php
@@ -2,7 +2,7 @@
 
 namespace test\PhpStaticAnalysis\PHPStanExtension;
 
-class ParamOutAttributeTest extends BaseAttributeTestCase
+final class ParamOutAttributeTest extends BaseAttributeTestCase
 {
     public function testMethodParamOutAttribute(): void
     {
diff --git a/tests/PropertyAttributeTest.php b/tests/PropertyAttributeTest.php
@@ -2,7 +2,7 @@
 
 namespace test\PhpStaticAnalysis\PHPStanExtension;
 
-class PropertyAttributeTest extends BaseAttributeTestCase
+final class PropertyAttributeTest extends BaseAttributeTestCase
 {
     public function testClassPropertyAttribute(): void
     {
diff --git a/tests/PropertyReadAttributeTest.php b/tests/PropertyReadAttributeTest.php
@@ -2,7 +2,7 @@
 
 namespace test\PhpStaticAnalysis\PHPStanExtension;
 
-class PropertyReadAttributeTest extends BaseAttributeTestCase
+final class PropertyReadAttributeTest extends BaseAttributeTestCase
 {
     public function testClassPropertyReadAttribute(): void
     {
diff --git a/tests/PropertyWriteAttributeTest.php b/tests/PropertyWriteAttributeTest.php
@@ -2,7 +2,7 @@
 
 namespace test\PhpStaticAnalysis\PHPStanExtension;
 
-class PropertyWriteAttributeTest extends BaseAttributeTestCase
+final class PropertyWriteAttributeTest extends BaseAttributeTestCase
 {
     public function testClassPropertyWriteAttribute(): void
     {
diff --git a/tests/PureAttributeTest.php b/tests/PureAttributeTest.php
@@ -2,7 +2,7 @@
 
 namespace test\PhpStaticAnalysis\PHPStanExtension;
 
-class PureAttributeTest extends BaseAttributeTestCase
+final class PureAttributeTest extends BaseAttributeTestCase
 {
     public function testMethodPureAttribute(): void
     {
diff --git a/tests/RequireExtendsAttributeTest.php b/tests/RequireExtendsAttributeTest.php
@@ -2,7 +2,7 @@
 
 namespace test\PhpStaticAnalysis\PHPStanExtension;
 
-class RequireExtendsAttributeTest extends BaseAttributeTestCase
+final class RequireExtendsAttributeTest extends BaseAttributeTestCase
 {
     public function testClassRequireExtendsAttribute(): void
     {
diff --git a/tests/RequireImplementsAttributeTest.php b/tests/RequireImplementsAttributeTest.php
@@ -2,7 +2,7 @@
 
 namespace test\PhpStaticAnalysis\PHPStanExtension;
 
-class RequireImplementsAttributeTest extends BaseAttributeTestCase
+final class RequireImplementsAttributeTest extends BaseAttributeTestCase
 {
     public function testClassRequireImplementsAttribute(): void
     {
diff --git a/tests/ReturnsAttributeTest.php b/tests/ReturnsAttributeTest.php
@@ -2,7 +2,7 @@
 
 namespace test\PhpStaticAnalysis\PHPStanExtension;
 
-class ReturnsAttributeTest extends BaseAttributeTestCase
+final class ReturnsAttributeTest extends BaseAttributeTestCase
 {
     public function testMethodReturnsAttribute(): void
     {
diff --git a/tests/SelfOutAttributeTest.php b/tests/SelfOutAttributeTest.php
@@ -2,7 +2,7 @@
 
 namespace test\PhpStaticAnalysis\PHPStanExtension;
 
-class SelfOutAttributeTest extends BaseAttributeTestCase
+final class SelfOutAttributeTest extends BaseAttributeTestCase
 {
     public function testMethodSelfOutAttribute(): void
     {
diff --git a/tests/TemplateAttributeTest.php b/tests/TemplateAttributeTest.php
@@ -2,7 +2,7 @@
 
 namespace test\PhpStaticAnalysis\PHPStanExtension;
 
-class TemplateAttributeTest extends BaseAttributeTestCase
+final class TemplateAttributeTest extends BaseAttributeTestCase
 {
     public function testClassTemplateAttribute(): void
     {
diff --git a/tests/TemplateContravariantAttributeTest.php b/tests/TemplateContravariantAttributeTest.php
@@ -2,7 +2,7 @@
 
 namespace test\PhpStaticAnalysis\PHPStanExtension;
 
-class TemplateContravariantAttributeTest extends BaseAttributeTestCase
+final class TemplateContravariantAttributeTest extends BaseAttributeTestCase
 {
     public function testClassTemplateContravariantAttribute(): void
     {
diff --git a/tests/TemplateCovariantAttributeTest.php b/tests/TemplateCovariantAttributeTest.php
@@ -2,7 +2,7 @@
 
 namespace test\PhpStaticAnalysis\PHPStanExtension;
 
-class TemplateCovariantAttributeTest extends BaseAttributeTestCase
+final class TemplateCovariantAttributeTest extends BaseAttributeTestCase
 {
     public function testClassTemplateCovariantAttribute(): void
     {
diff --git a/tests/TemplateExtendsAttributeTest.php b/tests/TemplateExtendsAttributeTest.php
@@ -2,7 +2,7 @@
 
 namespace test\PhpStaticAnalysis\PHPStanExtension;
 
-class TemplateExtendsAttributeTest extends BaseAttributeTestCase
+final class TemplateExtendsAttributeTest extends BaseAttributeTestCase
 {
     public function testClassTemplateExtendsAttribute(): void
     {
diff --git a/tests/TemplateImplementsAttributeTest.php b/tests/TemplateImplementsAttributeTest.php
@@ -2,7 +2,7 @@
 
 namespace test\PhpStaticAnalysis\PHPStanExtension;
 
-class TemplateImplementsAttributeTest extends BaseAttributeTestCase
+final class TemplateImplementsAttributeTest extends BaseAttributeTestCase
 {
     public function testInterfaceTemplateImplementsAttribute(): void
     {
diff --git a/tests/TemplateUseAttributeTest.php b/tests/TemplateUseAttributeTest.php
@@ -2,7 +2,7 @@
 
 namespace test\PhpStaticAnalysis\PHPStanExtension;
 
-class TemplateUseAttributeTest extends BaseAttributeTestCase
+final class TemplateUseAttributeTest extends BaseAttributeTestCase
 {
     public function testTraitTemplateUseAttribute(): void
     {
diff --git a/tests/ThrowsAttributeTest.php b/tests/ThrowsAttributeTest.php
@@ -2,7 +2,7 @@
 
 namespace test\PhpStaticAnalysis\PHPStanExtension;
 
-class ThrowsAttributeTest extends BaseAttributeTestCase
+final class ThrowsAttributeTest extends BaseAttributeTestCase
 {
     public function testMethodThrowsAttribute(): void
     {
diff --git a/tests/TypeAttributeTest.php b/tests/TypeAttributeTest.php
@@ -2,7 +2,7 @@
 
 namespace test\PhpStaticAnalysis\PHPStanExtension;
 
-class TypeAttributeTest extends BaseAttributeTestCase
+final class TypeAttributeTest extends BaseAttributeTestCase
 {
     public function testPropertyTypeAttribute(): void
     {

Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,7 @@`
`7`	`7`	`errorLevel="1"`
`8`	`8`	`findUnusedBaselineEntry="true"`
`9`	`9`	`findUnusedCode="false"`
	`10`	`+ ensureOverrideAttribute="false"`
`10`	`11`	`>`
`11`	`12`	`<projectFiles>`
`12`	`13`	`<directory name="src" />`
Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@`
`12`	`12`	`use PhpStaticAnalysis\NodeVisitor\AttributeNodeVisitor;`
`13`	`13`	`use Webmozart\Assert\Assert;`
`14`	`14`
`15`		`-class AttributeParser implements Parser`
	`15`	`+final class AttributeParser implements Parser`
`16`	`16`	`{`
`17`	`17`	`public function __construct(`
`18`	`18`	`private Parser $parser`
Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@`
`2`	`2`
`3`	`3`	`namespace test\PhpStaticAnalysis\PHPStanExtension;`
`4`	`4`
`5`		`-class AssertAttributeTest extends BaseAttributeTestCase`
	`5`	`+final class AssertAttributeTest extends BaseAttributeTestCase`
`6`	`6`	`{`
`7`	`7`	`public function testMethodAssertAttribute(): void`
`8`	`8`	`{`
Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`
`4`	`4`	`use test\PhpStaticAnalysis\PHPStanExtension\BaseAttributeTestCase;`
`5`	`5`
`6`		`-class AssertIfFalseAttributeTest extends BaseAttributeTestCase`
	`6`	`+final class AssertIfFalseAttributeTest extends BaseAttributeTestCase`
`7`	`7`	`{`
`8`	`8`	`public function testMethodAssertIfFalseAttribute(): void`
`9`	`9`	`{`
Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`
`4`	`4`	`use test\PhpStaticAnalysis\PHPStanExtension\BaseAttributeTestCase;`
`5`	`5`
`6`		`-class AssertIfTrueAttributeTest extends BaseAttributeTestCase`
	`6`	`+final class AssertIfTrueAttributeTest extends BaseAttributeTestCase`
`7`	`7`	`{`
`8`	`8`	`public function testMethodAssertIfTrueAttribute(): void`
`9`	`9`	`{`
Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@`
`2`	`2`
`3`	`3`	`namespace test\PhpStaticAnalysis\PHPStanExtension;`
`4`	`4`
`5`		`-class DefineTypeAttributeTest extends BaseAttributeTestCase`
	`5`	`+final class DefineTypeAttributeTest extends BaseAttributeTestCase`
`6`	`6`	`{`
`7`	`7`	`public function testClassDefineTypeAttribute(): void`
`8`	`8`	`{`
Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@`
`2`	`2`
`3`	`3`	`namespace test\PhpStaticAnalysis\PHPStanExtension;`
`4`	`4`
`5`		`-class DeprecatedAttributeTest extends BaseAttributeTestCase`
	`5`	`+final class DeprecatedAttributeTest extends BaseAttributeTestCase`
`6`	`6`	`{`
`7`	`7`	`public function testClassDeprecatedAttribute(): void`
`8`	`8`	`{`
Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`
`4`	`4`	`use test\PhpStaticAnalysis\PHPStanExtension\BaseAttributeTestCase;`
`5`	`5`
`6`		`-class ImmutableAttributeTest extends BaseAttributeTestCase`
	`6`	`+final class ImmutableAttributeTest extends BaseAttributeTestCase`
`7`	`7`	`{`
`8`	`8`	`public function testClassImmutableAttribute(): void`
`9`	`9`	`{`
Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@`
`2`	`2`
`3`	`3`	`namespace test\PhpStaticAnalysis\PHPStanExtension;`
`4`	`4`
`5`		`-class ImportTypeAttributeTest extends BaseAttributeTestCase`
	`5`	`+final class ImportTypeAttributeTest extends BaseAttributeTestCase`
`6`	`6`	`{`
`7`	`7`	`public function testClassImportTypeAttribute(): void`
`8`	`8`	`{`
Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@`
`2`	`2`
`3`	`3`	`namespace test\PhpStaticAnalysis\PHPStanExtension;`
`4`	`4`
`5`		`-class ImpureAttributeTest extends BaseAttributeTestCase`
	`5`	`+final class ImpureAttributeTest extends BaseAttributeTestCase`
`6`	`6`	`{`
`7`	`7`	`public function testMethodImpureAttribute(): void`
`8`	`8`	`{`
`@@ -22,7 +22,6 @@ public function testInvalidMethodImpureAttribute(): void`
`22`	`22`
`23`	`23`	`$expectedErrors = [`
`24`	`24`	`'Attribute class PhpStaticAnalysis\Attributes\Impure does not have the property target.' => 11,`
`25`		`- 'Method test\PhpStaticAnalysis\PHPStanExtension\data\Impure\InvalidMethodImpureAttribute::getMoreName() is marked as impure but does not have any side effects.' => 14,`
`26`	`25`	`];`
`27`	`26`
`28`	`27`	`$this->checkExpectedErrors($errors, $expectedErrors);`