Skip to content

Commit 4077f72

Browse files
committed
refac: use ConditionalTernary when possible
1 parent 3bfb69d commit 4077f72

File tree

1 file changed

+16
-6
lines changed

1 file changed

+16
-6
lines changed

Twig/Visitor/DefaultApplyingNodeVisitor.php

Lines changed: 16 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
use Twig\Node\Expression\ConditionalExpression;
1919
use Twig\Node\Expression\ConstantExpression;
2020
use Twig\Node\Expression\FilterExpression;
21+
use Twig\Node\Expression\Ternary\ConditionalTernary;
2122
use Twig\Node\Node;
2223
use Twig\NodeVisitor\AbstractNodeVisitor;
2324

@@ -103,12 +104,21 @@ public function doEnterNode(Node $node, Environment $env): Node
103104
);
104105
}
105106

106-
$condition = new ConditionalExpression(
107-
new EqualBinary($testNode, $transNode->getNode('node'), $wrappingNode->getTemplateLine()),
108-
$defaultNode,
109-
clone $wrappingNode,
110-
$wrappingNode->getTemplateLine()
111-
);
107+
if (Environment::VERSION_ID >= 31700) {
108+
$condition = new ConditionalTernary(
109+
new EqualBinary($testNode, $transNode->getNode('node'), $wrappingNode->getTemplateLine()),
110+
$defaultNode,
111+
clone $wrappingNode,
112+
$wrappingNode->getTemplateLine()
113+
);
114+
} else {
115+
$condition = new ConditionalExpression(
116+
new EqualBinary($testNode, $transNode->getNode('node'), $wrappingNode->getTemplateLine()),
117+
$defaultNode,
118+
clone $wrappingNode,
119+
$wrappingNode->getTemplateLine()
120+
);
121+
}
112122
$node->setNode('node', $condition);
113123

114124
return $node;

0 commit comments

Comments
 (0)