skip README.md generation in extension-init command if it exists

Author: IndraGunawan

caddy/extinit.go

@@ -14,13 +14,11 @@ import (
 func init() {
 	caddycmd.RegisterCommand(caddycmd.Command{
 		Name:  "extension-init",
-		Usage: "go_extension.go [--overwrite-readme]",
+		Usage: "go_extension.go",
 		Short: "Initializes a PHP extension from a Go file (EXPERIMENTAL)",
 		Long: `
 Initializes a PHP extension from a Go file. This command generates the necessary C files for the extension, including the header and source files, as well as the arginfo file.`,
 		CobraFunc: func(cmd *cobra.Command) {
-			cmd.Flags().BoolP("overwrite-readme", "r", false, "Overwrite README.md if it exists")
-
 			cmd.RunE = cmdInitExtension
 		},
 	})
@@ -31,15 +29,10 @@ func cmdInitExtension(cmd *cobra.Command, args []string) error {
 		return errors.New("the path to the Go source is required")
 	}
 
-	overwriteReadme, err := cmd.Flags().GetBool("overwrite-readme")
-	if err != nil {
-		return err
-	}
-
 	sourceFile := args[0]
 	baseName := extgen.SanitizePackageName(strings.TrimSuffix(filepath.Base(sourceFile), ".go"))
 
-	generator := extgen.Generator{BaseName: baseName, SourceFile: sourceFile, BuildDir: filepath.Dir(sourceFile), OverwriteReadme: overwriteReadme}
+	generator := extgen.Generator{BaseName: baseName, SourceFile: sourceFile, BuildDir: filepath.Dir(sourceFile)}
 
 	if err := generator.Generate(); err != nil {
 		return err

internal/extgen/docs.go

@@ -13,7 +13,6 @@ var docFileContent string
 
 type DocumentationGenerator struct {
 	generator *Generator
-	overwrite bool
 }
 
 type DocTemplateData struct {
@@ -25,7 +24,7 @@ type DocTemplateData struct {
 func (dg *DocumentationGenerator) generate() error {
 	filename := filepath.Join(dg.generator.BuildDir, "README.md")
 
-	if _, err := os.Stat(filename); err == nil && !dg.overwrite {
+	if _, err := os.Stat(filename); err == nil {
 		return nil
 	}
 

internal/extgen/docs_test.go

@@ -384,7 +384,7 @@ func BenchmarkDocumentationGenerator_GenerateMarkdown(b *testing.B) {
 	}
 }
 
-func TestDocumentationGenerator_OverwriteReadme(t *testing.T) {
+func TestDocumentationGenerator_SkipExistingReadme(t *testing.T) {
 	tempDir := t.TempDir()
 	readmePath := filepath.Join(tempDir, "README.md")
 
@@ -418,31 +418,4 @@ func TestDocumentationGenerator_OverwriteReadme(t *testing.T) {
 	require.NoError(t, err, "Failed to read generated README.md")
 
 	assert.Equal(t, string(content), "hello")
-
-	// regenerate
-	docGen = &DocumentationGenerator{
-		generator: generator,
-		overwrite: true,
-	}
-
-	err = docGen.generate()
-	assert.NoError(t, err, "generate() unexpected error")
-
-	content, err = os.ReadFile(readmePath)
-	require.NoError(t, err, "Failed to read generated README.md")
-
-	contentStr := string(content)
-
-	assert.Contains(t, contentStr, "# testextension Extension", "README should contain extension title")
-	assert.Contains(t, contentStr, "Auto-generated PHP extension from Go code.", "README should contain description")
-
-	if len(generator.Functions) > 0 {
-		assert.Contains(t, contentStr, "## Functions", "README should contain functions section when functions exist")
-
-		for _, fn := range generator.Functions {
-			assert.Contains(t, contentStr, "### "+fn.Name, "README should contain function %s", fn.Name)
-			assert.Contains(t, contentStr, fn.Signature, "README should contain function signature for %s", fn.Name)
-		}
-	}
-
 }

internal/extgen/generator.go

@@ -6,14 +6,13 @@ import (
 )
 
 type Generator struct {
-	BaseName        string
-	SourceFile      string
-	BuildDir        string
-	Functions       []phpFunction
-	Classes         []phpClass
-	Constants       []phpConstant
-	Namespace       string
-	OverwriteReadme bool
+	BaseName   string
+	SourceFile string
+	BuildDir   string
+	Functions  []phpFunction
+	Classes    []phpClass
+	Constants  []phpConstant
+	Namespace  string
 }
 
 // EXPERIMENTAL
@@ -132,7 +131,6 @@ func (g *Generator) generateGoFile() error {
 func (g *Generator) generateDocumentation() error {
 	docGen := DocumentationGenerator{
 		generator: g,
-		overwrite: g.OverwriteReadme,
 	}
 	if err := docGen.generate(); err != nil {
 		return &GeneratorError{"documentation generation", "failed to generate documentation", err}