ext/pgsql: Fix preprocessor guard typos that silently disabled features#21386
Closed
KentarouTakeda wants to merge 1 commit intophp:PHP-8.4from
Closed
ext/pgsql: Fix preprocessor guard typos that silently disabled features#21386KentarouTakeda wants to merge 1 commit intophp:PHP-8.4from
KentarouTakeda wants to merge 1 commit intophp:PHP-8.4from
Conversation
Member
|
seems you need to regenerate pgsql_arginfo.h |
Contributor
Author
|
Thanks for the review! Actually, this branch is already based on PHP-8.4 — I mistakenly opened the PR against master. These constants were added in PHP 8.3 and documented in the manual, but the preprocessor guard typos have prevented them from actually being available. Since PHP 8.3 is already in the "security fixes only" phase, PHP-8.4 is the correct target. I've changed the base branch to PHP-8.4, which should resolve the conflict and the arginfo issue. Does that sound reasonable? |
Member
|
only the typo would qualify as fix. |
Fix `PQTRACE_SUPPRESS_TIMESTAMPS` guard misspelling in pgsql.stub.php. The guard has been misspelled as `PQTRACE_SUPPPRESS_TIMESTAMPS` (three P's) since 7ec8ae1, preventing the `PGSQL_TRACE_SUPPRESS_TIMESTAMPS` constant from being registered.
KentarouTakeda
force-pushed
the
pgsql-fix-typos-in-preprocessor-guards
branch
from
c766785 to
8bc6e56
Compare
Contributor
Author
|
Thanks for the feedback! I've updated the PR to only include the |
devnexen
approved these changes
Mar 9, 2026
Member
|
Thanks ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove deadVE_PG_LO64guards frompg_lo_tell()/pg_lo_truncate().Bump minimum libpq version to 10.0 #14628 removedHAVE_PG_LO64from the build system and the corresponding guard inpg_lo_seek(), but missed these two functions. The leftover guards reference undefinedVE_PG_LO64(a misspelling of the removedHAVE_PG_LO64), making thelo_tell64()/lo_truncate64()code paths permanently dead.PQTRACE_SUPPRESS_TIMESTAMPSguard misspelling in pgsql.stub.php.The guard has been misspelled as
PQTRACE_SUPPPRESS_TIMESTAMPS(three P's) since 7ec8ae1, preventing thePGSQL_TRACE_SUPPRESS_TIMESTAMPSconstant from being registered.