Limit the depth when resolving closure type for performance reasons

Author: ondrejmirtes

src/Analyser/MutatingScope.php

@@ -180,6 +180,8 @@ class MutatingScope implements Scope
 
 	private ?self $scopeWithPromotedNativeTypes = null;
 
+	private static int $resolveClosureTypeDepth = 0;
+
 	/**
 	 * @param array<string, ExpressionTypeHolder> $expressionTypes
 	 * @param array<string, ConditionalExpressionHolder[]> $conditionalExpressions
@@ -1322,6 +1324,16 @@ static function (Node $node, Scope $scope) use ($arrowScope, &$arrowFunctionImpu
 				$closureExecutionEnds = [];
 				$closureImpurePoints = [];
 				$invalidateExpressions = [];
+				if (self::$resolveClosureTypeDepth >= 2) {
+					return new ClosureType(
+						$parameters,
+						$this->getFunctionType($node->returnType, false, false),
+						$isVariadic,
+					);
+				}
+
+				self::$resolveClosureTypeDepth++;
+				try {
 					$closureStatementResult = $this->nodeScopeResolver->processStmtNodes($node, $node->stmts, $closureScope, static function (Node $node, Scope $scope) use ($closureScope, &$closureReturnStatements, &$closureYieldStatements, &$closureExecutionEnds, &$closureImpurePoints, &$invalidateExpressions): void {
 						if ($scope->getAnonymousFunctionReflection() !== $closureScope->getAnonymousFunctionReflection()) {
 							return;
@@ -1372,6 +1384,9 @@ static function (Node $node, Scope $scope) use ($arrowScope, &$arrowFunctionImpu
 
 						$closureYieldStatements[] = [$node, $scope];
 					}, StatementContext::createTopLevel());
+				} finally {
+					self::$resolveClosureTypeDepth--;
+				}
 
 				$throwPoints = $closureStatementResult->getThrowPoints();
 				$impurePoints = array_merge($closureImpurePoints, $closureStatementResult->getImpurePoints());