Skip to content

Commit 5b37406

Browse files
committed
Remove todos
1 parent 7ed316d commit 5b37406

File tree

3 files changed

+1
-11
lines changed

3 files changed

+1
-11
lines changed

src/Reflection/GenericParametersAcceptorResolver.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,6 @@ public static function resolve(array $argTypes, ParametersAcceptor $parametersAc
2727
}
2828

2929
$paramType = $param->getType();
30-
31-
// todo zde "doaplikovat" typy, ktere se dosud nevyskytly - typicky callable(T) - parametr callable
3230
$typeMap = $typeMap->union($paramType->inferTemplateTypes($argType));
3331
}
3432

tests/PHPStan/Rules/Comparison/StrictComparisonOfDifferentTypesRuleTest.php

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -154,10 +154,6 @@ public function testStrictComparison(): void
154154
'Strict comparison using === between 0 and 0 will always evaluate to true.',
155155
426,
156156
],
157-
[
158-
'Strict comparison using === between int and null will always evaluate to false.', // todo remove with isDeterministic
159-
438,
160-
],
161157
[
162158
'Strict comparison using === between int<min, 0>|int<2, max>|string and 1.0 will always evaluate to false.',
163159
464,
@@ -332,10 +328,6 @@ public function testStrictComparisonWithoutAlwaysTrue(): void
332328
'Strict comparison using !== between null and null will always evaluate to false.',
333329
408,
334330
],
335-
[
336-
'Strict comparison using === between int and null will always evaluate to false.', // todo remove with isDeterministic
337-
438,
338-
],
339331
[
340332
'Strict comparison using === between int<min, 0>|int<2, max>|string and 1.0 will always evaluate to false.',
341333
464,

tests/PHPStan/Rules/Comparison/data/strict-comparison.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -440,7 +440,7 @@ public function doFoo()
440440
}
441441
}
442442
}
443-
443+
/** @phpstan-impure */
444444
public function nullableInt(): ?int
445445
{
446446

0 commit comments

Comments
 (0)