Refactor DontFragmentAttr to DontFragment

And add an deprecated type alias.

Author: stv0g

internal/proto/dontfrag.go

@@ -4,19 +4,30 @@ import (
 	"github.com/pion/stun"
 )
 
-// DontFragmentAttr represents DONT-FRAGMENT attribute.
-type DontFragmentAttr struct{}
+// DontFragmentAttr is a deprecated alias for DontFragment
+// Deprecated: Please use DontFragment
+type DontFragmentAttr = DontFragment
+
+// DontFragment represents DONT-FRAGMENT attribute.
+//
+// This attribute is used by the client to request that the server set
+// the DF (Don't Fragment) bit in the IP header when relaying the
+// application data onward to the peer.  This attribute has no value
+// part and thus the attribute length field is 0.
+//
+// RFC 5766 Section 14.8
+type DontFragment struct{}
 
 const dontFragmentSize = 0
 
 // AddTo adds DONT-FRAGMENT attribute to message.
-func (DontFragmentAttr) AddTo(m *stun.Message) error {
+func (DontFragment) AddTo(m *stun.Message) error {
 	m.Add(stun.AttrDontFragment, nil)
 	return nil
 }
 
 // GetFrom decodes DONT-FRAGMENT from message.
-func (d *DontFragmentAttr) GetFrom(m *stun.Message) error {
+func (d *DontFragment) GetFrom(m *stun.Message) error {
 	v, err := m.Get(stun.AttrDontFragment)
 	if err != nil {
 		return err
@@ -28,7 +39,7 @@ func (d *DontFragmentAttr) GetFrom(m *stun.Message) error {
 }
 
 // IsSet returns true if DONT-FRAGMENT attribute is set.
-func (DontFragmentAttr) IsSet(m *stun.Message) bool {
+func (DontFragment) IsSet(m *stun.Message) bool {
 	_, err := m.Get(stun.AttrDontFragment)
 	return err == nil
 }

internal/proto/dontfrag_test.go

@@ -7,18 +7,18 @@ import (
 )
 
 func TestDontFragment(t *testing.T) {
-	var DontFragment DontFragmentAttr
+	var dontFrag DontFragment
 
 	t.Run("False", func(t *testing.T) {
 		m := new(stun.Message)
 		m.WriteHeader()
-		if DontFragment.IsSet(m) {
+		if dontFrag.IsSet(m) {
 			t.Error("should not be set")
 		}
 	})
 	t.Run("AddTo", func(t *testing.T) {
 		m := new(stun.Message)
-		if err := DontFragment.AddTo(m); err != nil {
+		if err := dontFrag.AddTo(m); err != nil {
 			t.Error(err)
 		}
 		m.WriteHeader()
@@ -27,11 +27,11 @@ func TestDontFragment(t *testing.T) {
 			if _, err := decoded.Write(m.Raw); err != nil {
 				t.Fatal("failed to decode message:", err)
 			}
-			if !DontFragment.IsSet(m) {
+			if !dontFrag.IsSet(m) {
 				t.Error("should be set")
 			}
 			if wasAllocs(func() {
-				DontFragment.IsSet(m)
+				dontFrag.IsSet(m)
 			}) {
 				t.Error("unexpected allocations")
 			}