trackDetailsFromSDP should also black list FEC ssrc #3109
Comments
|
Should we just remove Plan-B support @3DRX? I hope no one is still using it! |
|
@Sean-Der I think we should, since it’s not actually in WebRTC standard and google drops the plan b support a while ago. |
2 tasks
|
@Sean-Der I think with this pr, we can delay the decision of dropping plan b support. Since the issue here is any sdp with a FEC ssrc included will be treated as plan b by pion and caused an error after SetRemoteDescription, which shouldn't happen. Fully supporting receiving fec in pion is way harder (I'm trying, but it's harder than I initially thought), but with this PR pion doesn't return this wrong error message anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
The Problem
Unified plan SDP can contain FEC and RTX tracks in the same m= with video track, https://datatracker.ietf.org/doc/html/draft-roach-mmusic-unified-plan-00#section-4.5 .
But currently, pion's implementation thinks it's plan B sdp if FEC track is included.
The Cause
It seems like the problem is in function
trackDetailsFromSDPof sdp.go, it only black lists rtx ssrc, but not fec ssrc.The Fix
We should also black list fec ssrc in
trackDetailsFromSDP. And also testdescriptionIsPlanBagainst examples in https://datatracker.ietf.org/doc/html/draft-roach-mmusic-unified-plan-00#section-4 .The text was updated successfully, but these errors were encountered: