Skip to content

Commit 19d952a

Browse files
committed
Fix exception causes all over the codebase
1 parent 688ea09 commit 19d952a

File tree

3 files changed

+12
-12
lines changed

3 files changed

+12
-12
lines changed

smart_open/s3.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -270,7 +270,7 @@ def _get(s3_object, version=None, **kwargs):
270270
'unable to access bucket: %r key: %r version: %r error: %s' % (
271271
s3_object.bucket_name, s3_object.key, version, error
272272
)
273-
)
273+
) from error
274274

275275

276276
class _SeekableRawReader(object):
@@ -610,7 +610,7 @@ def __init__(
610610
'the bucket %r does not exist, or is forbidden for access (%r)' % (
611611
bucket, error
612612
)
613-
)
613+
) from error
614614

615615
self._buf = io.BytesIO()
616616
self._total_bytes = 0
@@ -790,8 +790,8 @@ def __init__(
790790
try:
791791
self._object = s3.Object(bucket, key)
792792
s3.meta.client.head_bucket(Bucket=bucket)
793-
except botocore.client.ClientError:
794-
raise ValueError('the bucket %r does not exist, or is forbidden for access' % bucket)
793+
except botocore.client.ClientError as e:
794+
raise ValueError('the bucket %r does not exist, or is forbidden for access' % bucket) from e
795795

796796
self._buf = io.BytesIO()
797797
self._total_bytes = 0
@@ -815,9 +815,9 @@ def close(self):
815815

816816
try:
817817
self._object.put(Body=self._buf, **self._upload_kwargs)
818-
except botocore.client.ClientError:
818+
except botocore.client.ClientError as e:
819819
raise ValueError(
820-
'the bucket %r does not exist, or is forbidden for access' % self._object.bucket_name)
820+
'the bucket %r does not exist, or is forbidden for access' % self._object.bucket_name) from e
821821

822822
logger.debug("direct upload finished")
823823
self._buf = None

smart_open/tests/test_gcs.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,8 @@ def exists(self):
7272
def get_blob(self, blob_id):
7373
try:
7474
return self.blobs[blob_id]
75-
except KeyError:
76-
raise google.cloud.exceptions.NotFound('Blob {} not found'.format(blob_id))
75+
except KeyError as e:
76+
raise google.cloud.exceptions.NotFound('Blob {} not found'.format(blob_id)) from e
7777

7878
def list_blobs(self):
7979
return list(self.blobs.values())
@@ -246,8 +246,8 @@ def __init__(self, credentials=None):
246246
def bucket(self, bucket_id):
247247
try:
248248
return self.__buckets[bucket_id]
249-
except KeyError:
250-
raise google.cloud.exceptions.NotFound('Bucket %s not found' % bucket_id)
249+
except KeyError as e:
250+
raise google.cloud.exceptions.NotFound('Bucket %s not found' % bucket_id) from e
251251

252252
def create_bucket(self, bucket_id):
253253
bucket = FakeBucket(self, bucket_id)

smart_open/transport.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,8 @@ def get_transport(scheme):
7272
)
7373
try:
7474
submodule = _REGISTRY[scheme]
75-
except KeyError:
76-
raise NotImplementedError(message)
75+
except KeyError as e:
76+
raise NotImplementedError(message) from e
7777
else:
7878
return submodule
7979

0 commit comments

Comments
 (0)