Added default namespace for search attribute data source

Author: amibaid

internal/provider/search_attribute_data_source.go

@@ -59,8 +59,8 @@ func (d *SearchAttributeDataSource) Schema(ctx context.Context, req datasource.S
 				Computed:            true,
 			},
 			"namespace": schema.StringAttribute{
-				MarkdownDescription: "Namespace with which the Search Attribute is associated",
-				Required:            true,
+				MarkdownDescription: "Namespace with which the Search Attribute is associated. If this is not provided, 'default' will be used",
+				Optional:            true,
 			},
 		},
 	}
@@ -94,7 +94,8 @@ func (d *SearchAttributeDataSource) Configure(ctx context.Context, req datasourc
 func (d *SearchAttributeDataSource) Read(ctx context.Context, req datasource.ReadRequest, resp *datasource.ReadResponse) {
 	tflog.Info(ctx, "Reading Temporal Search Attribute")
 
-	var name, namespace string
+	var name string
+	var namespace types.String
 
 	// Get the 'name' and 'namespace' attributes from the configuration
 	diags := req.Config.GetAttribute(ctx, path.Root("name"), &name)
@@ -109,8 +110,13 @@ func (d *SearchAttributeDataSource) Read(ctx context.Context, req datasource.Rea
 		return
 	}
 
+	// If the user has not provided a namespace for the data source, use 'default'
+	if namespace.IsNull() {
+		namespace = types.StringValue("default")
+	}
+
 	request := &operatorservice.ListSearchAttributesRequest{
-		Namespace: namespace,
+		Namespace: namespace.ValueString(),
 	}
 
 	// Calling API for existing attribute details
@@ -133,7 +139,7 @@ func (d *SearchAttributeDataSource) Read(ctx context.Context, req datasource.Rea
 	data := &SearchAttributeDataSourceModel{
 		Name:      types.StringValue(name),
 		Type:      types.StringValue(attributeType.String()),
-		Namespace: types.StringValue(namespace),
+		Namespace: namespace,
 	}
 
 	// Save the fetched data into Terraform state

internal/provider/search_attribute_data_source_test.go

@@ -12,11 +12,12 @@ func TestAccSearchAttributeDataSource(t *testing.T) {
 
 		Steps: []resource.TestStep{
 			// Test reading from the server and setting data source attributes
+
+			// Test reading data source without explicitly proving namespace, should use 'default'
 			{
 				Config: providerConfig + `
                 data "temporal_search_attribute" "example" {
                     name = "RunId"
-                    namespace = "default"
                 }`,
 
 				Check: resource.ComposeAggregateTestCheckFunc(
@@ -25,6 +26,21 @@ func TestAccSearchAttributeDataSource(t *testing.T) {
 					resource.TestCheckResourceAttr("data.temporal_search_attribute.example", "namespace", "default"),
 				),
 			},
+
+			// Test reading with provided namespace
+			{
+				Config: providerConfig + `
+                data "temporal_search_attribute" "example" {
+                    name = "HistoryLength"
+					namespace = "default"
+                }`,
+
+				Check: resource.ComposeAggregateTestCheckFunc(
+					resource.TestCheckResourceAttr("data.temporal_search_attribute.example", "name", "HistoryLength"),
+					resource.TestCheckResourceAttr("data.temporal_search_attribute.example", "type", "Int"), // Verify that the type was read correctly from the server
+					resource.TestCheckResourceAttr("data.temporal_search_attribute.example", "namespace", "default"),
+				),
+			},
 		},
 	})
 }