Skip to content

Question regarding an ESP32 Core commit #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GeorgeFlorian opened this issue Jul 29, 2019 · 7 comments
Closed

Question regarding an ESP32 Core commit #212

GeorgeFlorian opened this issue Jul 29, 2019 · 7 comments

Comments

@GeorgeFlorian
Copy link

Hello !

I need to include the following commit into PIO: espressif/arduino-esp32@b0d8d4d

How can I do that ?

@GeorgeFlorian GeorgeFlorian changed the title Question regarding a ESP32 Core commit Question regarding an ESP32 Core commit Jul 29, 2019
@valeros
Copy link
Member

valeros commented Jul 29, 2019

You can try to compile your project using the staging version of the platform

@GeorgeFlorian
Copy link
Author

GeorgeFlorian commented Jul 29, 2019

You can try to compile your project using the staging version of the platform

Thank you for your reply.
I am afraid that the Stage version will break my code.
Also, can you please check this thread: https://community.platformio.org/t/how-to-properly-modify-sdkconfig-change-some-values-save-it-and-thats-it/8951/2 ?

I have found both sdkconfig and modified them like in the commit but I have no idea if or how will it take effect.
Do I just save those files, build and upload my code ?

@joba-1
Copy link

joba-1 commented Jul 29, 2019

isn't that obvious?

Changing stable might break the code of everyone else. Not an option (with very few exceptions that I think do not apply here).

What I would do is

  1. fork stable, add your change and use that fork for your project.
  2. fork staging, add your change and create a pull request with arguments why this change is necessary and safe. This way you might be able to stop maintaining your own stable fork with the next stable release.

@atanisoft
Copy link
Contributor

@GeorgeFlorian You can copy sdkconfig.h to your project src directory and it will be included instead of the copy in the framework directories. You can safely modify some of the parameters in the sdkconfig.h as listed in espressif/arduino-esp32#2899.

@GeorgeFlorian
Copy link
Author

@GeorgeFlorian You can copy sdkconfig.h to your project src directory and it will be included instead of the copy in the framework directories. You can safely modify some of the parameters in the sdkconfig.h as listed in espressif/arduino-esp32#2899.

Great to know ! Will definitely try ! Thanks !

@GeorgeFlorian
Copy link
Author

GeorgeFlorian commented Aug 5, 2019

@GeorgeFlorian You can copy sdkconfig.h to your project src directory and it will be included instead of the copy in the framework directories. You can safely modify some of the parameters in the sdkconfig.h as listed in espressif/arduino-esp32#2899.

What about the other sdkconfig file, the one that is a text document ?
If I only copy sdkconfig.h to the src directory and modify it accordingly, what happens to the other sdkconfig. Will it change ? Do I have to change it ?

Also, one noob question: do I have to #include <sdkconfig.h> in the main.cpp ?

@atanisoft
Copy link
Contributor

What about the other sdkconfig file, the one that is a text document ?

This is not used at compilation time, it is used by the "make menuconfig" utility to generate the sdkconfig.h file which configures the compilation side of configuration.

Also, one noob question: do I have to #include <sdkconfig.h> in the main.cpp ?

Nope, it will be included automatically by the components that require it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants