Skip to content

react and react-dom should be in dev-dependencies #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bpostlethwaite opened this issue Nov 12, 2018 · 3 comments
Closed

react and react-dom should be in dev-dependencies #39

bpostlethwaite opened this issue Nov 12, 2018 · 3 comments
Assignees
@T4rk1n

Comments

@bpostlethwaite
Copy link
Member

react and react-dom are supplied by dash-renderer.

Also we need to update our Component Author documentation to make this clear (in case it isn't).
@T4rk1n
Copy link
Contributor

T4rk1n commented Nov 12, 2018

It's in peer dependencies.

@nicolaskruchten
Copy link
Contributor

it's also in dependencies, but it shouldn't be :)

@bpostlethwaite
Copy link
Member Author

added note in dash-docs to include information about this for component authors https://github.com/plotly/dash-docs/issues/227#issuecomment-438271930

@T4rk1n T4rk1n mentioned this issue Nov 13, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@T4rk1n T4rk1n

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nicolaskruchten @bpostlethwaite @T4rk1n