Skip to content
This repository was archived by the owner on Jun 4, 2024. It is now read-only.

Make lint fail build when there are linting errors #106

Closed
Marc-Andre-Rivet opened this issue Dec 7, 2018 · 1 comment
Closed

Make lint fail build when there are linting errors #106

Marc-Andre-Rivet opened this issue Dec 7, 2018 · 1 comment
Labels
Type: Maintenance Technical debt, dependency management, additional testing, etc.

Comments

@Marc-Andre-Rivet
Copy link
Contributor

The current npm lint command has the --quiet, which means that when running this command in CI and will not fail the build.

Suggest splitting this in two commands

  • lint checks and fails on linting errors
  • lint.fix checks and fixes linting errors if it can (retaining the current dev-side work case)
@Marc-Andre-Rivet Marc-Andre-Rivet added the Type: Maintenance Technical debt, dependency management, additional testing, etc. label Dec 12, 2018
@alexcjohnson
Copy link
Collaborator

@valentijnnieman fixed this in #75

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Type: Maintenance Technical debt, dependency management, additional testing, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexcjohnson @Marc-Andre-Rivet