Skip to content
This repository was archived by the owner on Jun 4, 2024. It is now read-only.

Ability to save input when clicking outside of the table [Sponsored: Due Feb 1] #308

Closed
chriddyp opened this issue Dec 18, 2018 · 3 comments
Labels
dash-meta-sponsored Development that has been sponsored by an organization https://plot.ly/products/consulting-and-oem/ dash-type-bug Something isn't working as intended

Comments

@chriddyp
Copy link
Member

Currently, if you are editing a value in the table, clicking outside of the table will not save persist the value.

@Marc-Andre-Rivet Marc-Andre-Rivet added the dash-meta-sponsored Development that has been sponsored by an organization https://plot.ly/products/consulting-and-oem/ label Dec 19, 2018
@chriddyp chriddyp changed the title dash-table: Ability to save input when clicking outside of the table [Sponsored: Due Feb 1] Ability to save input when clicking outside of the table [Sponsored: Due Feb 1] Dec 19, 2018
@Marc-Andre-Rivet
Copy link
Contributor

@chriddyp I've tried this on 3.1.11 and it seems to be persisting the value correctly when clicking outside the table. I've been using this small Dash app as a base https://github.com/plotly/dash-table/blob/master/tests/cypress/dash/v_be_page.py and added a dcc.Input(id="input", value="Foo") -- when clicking in either the body or the added input. Tested with input fields only, as dropdown fields are not subject to this problem (auto-closes / apply value on selection).

The cell implementation has been extensively refactored in December, so the issue was possibly resolved during the refactor (#281)?

Can you confirm if you are still experiencing this issue and provide an example if that's the case. Thanks.

@chriddyp
Copy link
Member Author

chriddyp commented Jan 8, 2019

I can't replicate this anymore, looks fixed now 🎉

@chriddyp chriddyp closed this as completed Jan 8, 2019
@choprashweta
Copy link

I am still facing this issue with Dash Table 4.7.0 after double-clicking inside the cell before entering values. Upon clicking outside or clicking a button, the entered values do not persist. Issue has been illustrated here: https://community.plotly.com/t/double-click-the-input-field-in-dashtable-then-use-a-button-to-save-the-content-will-loss/25292

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dash-meta-sponsored Development that has been sponsored by an organization https://plot.ly/products/consulting-and-oem/ dash-type-bug Something isn't working as intended
Projects
None yet
Development

No branches or pull requests

3 participants