Merge pull request #461 from plotly/assets-snapshots

T4rk1n · web-flow · commit dcd0f4150482 · 2018-11-19T15:51:02.000-05:00
Add assets css to percy snapshots
diff --git a/tests/IntegrationTests.py b/tests/IntegrationTests.py
@@ -38,7 +38,9 @@ def setUpClass(cls):
         cls.driver = webdriver.Chrome()
 
         loader = percy.ResourceLoader(
-            webdriver=cls.driver
+            webdriver=cls.driver,
+            base_url='/assets',
+            root_dir='tests/assets'
         )
         cls.percy_runner = percy.Runner(loader=loader)
 
diff --git a/tests/assets/nested_css/nested.css b/tests/assets/nested_css/nested.css
@@ -1,3 +1,4 @@
 #content {
     padding: 8px;
+    background-color: purple;
 }
diff --git a/tests/test_integration.py b/tests/test_integration.py
@@ -362,7 +362,6 @@ def test_index_customization(self):
     def test_assets(self):
         app = dash.Dash(__name__,
                         assets_folder='tests/assets',
-                        assets_url_path='/test-assets',
                         assets_ignore='.*ignored.*')
         app.index_string = '''
         <!DOCTYPE html>
@@ -384,7 +383,7 @@ def test_assets(self):
         '''
 
         app.layout = html.Div([
-            html.Div(id='content'),
+            html.Div('Content', id='content'),
             dcc.Input(id='test')
         ], id='layout')
 

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,9 @@ def setUpClass(cls):`
`38`	`38`	`cls.driver = webdriver.Chrome()`
`39`	`39`
`40`	`40`	`loader = percy.ResourceLoader(`
`41`		`- webdriver=cls.driver`
	`41`	`+ webdriver=cls.driver,`
	`42`	`+ base_url='/assets',`
	`43`	`+ root_dir='tests/assets'`
`42`	`44`	`)`
`43`	`45`	`cls.percy_runner = percy.Runner(loader=loader)`
`44`	`46`