Skip to content

Hot reloading interval control for non-asset files in app directory requires improvement #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rpkyle opened this issue Nov 15, 2019 · 0 comments
Assignees
Labels

Comments

@rpkyle
Copy link
Contributor

rpkyle commented Nov 15, 2019

Initial hot reloading support was provided in #127, including parameters dev_tools_hot_reload_interval and dev_tools_hot_reload_watch_interval.

The initial implementation of hot reloading did not permit a hot reload on initial update to the app itself, and performed a check based on the last event loop (cycle) end time.

Since fiery defaults to updating every 0.1 seconds, this prevented hot reloads for edits to files in the application root directory, while updating assets did trigger a reload event.

A more robust implementation would track whether a hot reload has been performed at least once, and always set permit_reload = TRUE until one reload event has occurred.

On subsequent cycles, it would then be possible to compare the current cycle (wall) time against the (wall) time of the previous reload event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant