Skip to content

Update windrose examples to use barpolar #1100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jonmmease opened this issue Sep 23, 2018 · 6 comments
Closed

Update windrose examples to use barpolar #1100

jonmmease opened this issue Sep 23, 2018 · 6 comments
Assignees

Comments

@jonmmease
Copy link
Contributor

Plotly.js 1.41 will be included in the plotly.py 3.3 release next week and it would be nice to have some barpolar documentation examples to reference in the release announcement.

To start with, would anyone have time to port the JavaScript and Python wind rose examples (https://plot.ly/python/wind-rose-charts/) from area to barpolar?

cc @etpinard @jackparmer

@jackparmer
Copy link
Contributor

@Kully or @michaelbabyn Can you please take this (whoever gets to it first)

The old area wind roses essentially shouldn't be in the docs anymore, they're deprecated with barpolar

@Kully
Copy link
Contributor

Kully commented Sep 24, 2018

@Kully or @michaelbabyn Can you please take this (whoever gets to it first)

I got it!

@Kully
Copy link
Contributor

Kully commented Sep 25, 2018

As we don't have Barpolar in master yet, I am just going to replace the Area text but not run the examples.

So I don't have to redo the work a second time, is the spelling going to be go.BarPolar(...) or go.Barpolar(...)?

@jonmmease
Copy link
Contributor Author

It will be Barpolar, and hopefully I'll have a release candidate published by tomorrow morning. And we'll need to run the examples before publishing right? So that the barpolar trace is displayed rather than area.

Thanks @Kully!

@jonmmease
Copy link
Contributor Author

Here's the branch with barpolar in it plotly/plotly.py#1202. I'm hitting an issue using barpolar with FigureWidget that I need to work through before we release this but it's in fine shape for the docs.

@jonmmease
Copy link
Contributor Author

@Kully 3.3.0rc1 with barpolar support has been published to PyPI and anaconda cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants