refactor: avoid unnecessary glob expansion

salim-b · salim-b · commit b96d782064b9 · 2024-09-04T17:43:42.000+02:00
diff --git a/tools/update_plotlyjs.R b/tools/update_plotlyjs.R
@@ -63,7 +63,7 @@ withr::with_dir(tmpdir, {
         overwrite = TRUE
       )
       # update plot schema and (partial) bundles
-      Schema <- jsonlite::fromJSON(Sys.glob("dist/plot-schema.json"))
+      Schema <- jsonlite::fromJSON("dist/plot-schema.json")
       bundleTraceMap <-
         paste0(readLines("tasks/util/constants.js"), collapse = "\n") |>
         stringr::str_extract(pattern = "(?<=\\b(const|var) partialBundleTraces = )\\{[^}]+\\}") |>

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ withr::with_dir(tmpdir, {`
`63`	`63`	`overwrite = TRUE`
`64`	`64`	`)`
`65`	`65`	`# update plot schema and (partial) bundles`
`66`		`- Schema <- jsonlite::fromJSON(Sys.glob("dist/plot-schema.json"))`
	`66`	`+ Schema <- jsonlite::fromJSON("dist/plot-schema.json")`
`67`	`67`	`bundleTraceMap <-`
`68`	`68`	`paste0(readLines("tasks/util/constants.js"), collapse = "\n") \|>`
`69`	`69`	`stringr::str_extract(pattern = "(?<=\\b(const\|var) partialBundleTraces = )\\{[^}]+\\}") \|>`