Skip to content

Commit 346319c

Browse files
archmojarchmoj
committed
Revert "add user-select-none to text elements"
This reverts commit b9dad67.
1 parent b9dad67 commit 346319c

File tree

18 files changed

+14
-46
lines changed

18 files changed

+14
-46
lines changed

‎src/components/annotations/draw.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -217,9 +217,7 @@ function drawRaw(gd, options, index, subplotId, xa, ya) {
217217
Lib.templateString(options.text, fullLayout._meta) :
218218
options.text;
219219

220-
var annText = annTextGroupInner
221-
.classed('user-select-none', true)
222-
.append('text')
220+
var annText = annTextGroupInner.append('text')
223221
.classed('annotation-text', true)
224222
.text(text);
225223

‎src/components/colorbar/draw.js

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -53,11 +53,7 @@ function draw(gd) {
5353
Lib.ensureSingle(g, 'g', cn.cbfills);
5454
Lib.ensureSingle(g, 'g', cn.cblines);
5555
Lib.ensureSingle(g, 'g', cn.cbaxis, function(s) { s.classed(cn.crisp, true); });
56-
Lib.ensureSingle(g, 'g', cn.cbtitleunshift, function(s) {
57-
s.append('g')
58-
.classed('user-select-none', true)
59-
.classed(cn.cbtitle, true);
60-
});
56+
Lib.ensureSingle(g, 'g', cn.cbtitleunshift, function(s) { s.append('g').classed(cn.cbtitle, true); });
6157
Lib.ensureSingle(g, 'rect', cn.cboutline);
6258

6359
var done = drawColorBar(g, opts, gd);

‎src/components/fx/hover.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -813,7 +813,6 @@ function createHoverText(hoverData, opts, gd) {
813813
var commonLabel = container.selectAll('g.axistext')
814814
.data(showCommonLabel ? [0] : []);
815815
commonLabel.enter().append('g')
816-
.classed('user-select-none', true)
817816
.classed('axistext', true);
818817
commonLabel.exit().remove();
819818

@@ -1084,7 +1083,6 @@ function createHoverText(hoverData, opts, gd) {
10841083
return hoverDataKey(d);
10851084
});
10861085
hoverLabels.enter().append('g')
1087-
.classed('user-select-none', true)
10881086
.classed('hovertext', true)
10891087
.each(function() {
10901088
var g = d3.select(this);

‎src/components/legend/style.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -282,10 +282,8 @@ module.exports = function style(s, gd, legend) {
282282
var txt = ptgroup.selectAll('g.pointtext')
283283
.data(showText ? dMod : []);
284284
txt.enter()
285-
.append('g')
286-
.classed('user-select-none', true)
287-
.classed('pointtext', true)
288-
.append('text').attr('transform', 'translate(20,0)');
285+
.append('g').classed('pointtext', true)
286+
.append('text').attr('transform', 'translate(20,0)');
289287
txt.exit().remove();
290288
txt.selectAll('text').call(Drawing.textPointStyle, tMod, gd);
291289
}

‎src/components/titles/index.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,8 +105,7 @@ function draw(gd, titleClass, options) {
105105
var elShouldExist = txt || editable;
106106

107107
if(!group) {
108-
group = Lib.ensureSingle(fullLayout._infolayer, 'g', 'g-' + titleClass)
109-
.classed('user-select-none', true);
108+
group = Lib.ensureSingle(fullLayout._infolayer, 'g', 'g-' + titleClass);
110109
}
111110

112111
var el = group.selectAll('text')

‎src/plots/cartesian/axes.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2732,7 +2732,6 @@ axes.drawLabels = function(gd, ax, opts) {
27322732
var labelsReady = [];
27332733

27342734
tickLabels.enter().append('g')
2735-
.classed('user-select-none', true)
27362735
.classed(cls, 1)
27372736
.append('text')
27382737
// only so tex has predictable alignment that we can

‎src/traces/bar/plot.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,6 @@ function plot(gd, plotinfo, cdModule, traceLayer, opts, makeOnCompleteCallback)
122122
var bars = pointGroup.selectAll('g.point').data(Lib.identity, keyFunc);
123123

124124
bars.enter().append('g')
125-
.classed('user-select-none', true)
126125
.classed('point', true);
127126

128127
bars.exit().remove();

‎src/traces/carpet/plot.js

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,7 @@ module.exports = function plot(gd, plotinfo, cdcarpet, carpetLayer) {
3434
var minorLayer = Lib.ensureSingle(axisLayer, 'g', 'minorlayer');
3535
var majorLayer = Lib.ensureSingle(axisLayer, 'g', 'majorlayer');
3636
var boundaryLayer = Lib.ensureSingle(axisLayer, 'g', 'boundarylayer');
37-
var labelLayer = Lib.ensureSingle(axisLayer, 'g', 'labellayer')
38-
.classed('user-select-none', true);
37+
var labelLayer = Lib.ensureSingle(axisLayer, 'g', 'labellayer');
3938

4039
axisLayer.style('opacity', trace.opacity);
4140

@@ -207,8 +206,7 @@ function drawAxisTitle(gd, layer, trace, t, xy, dxy, axis, xa, ya, labelOrientat
207206
var titleJoin = layer.selectAll('text.' + labelClass).data(data);
208207
var offset = labelOrientation.maxExtent;
209208

210-
titleJoin.enter()
211-
.append('text')
209+
titleJoin.enter().append('text')
212210
.classed(labelClass, true);
213211

214212
// There's only one, but we'll do it as a join so it's updated nicely:
@@ -229,8 +227,7 @@ function drawAxisTitle(gd, layer, trace, t, xy, dxy, axis, xa, ya, labelOrientat
229227

230228
var el = d3.select(this);
231229

232-
el.classed('user-select-none', true)
233-
.text(axis.title.text)
230+
el.text(axis.title.text)
234231
.call(svgTextUtils.convertToTspans, gd);
235232

236233
if(reverseTitle) {
@@ -242,6 +239,7 @@ function drawAxisTitle(gd, layer, trace, t, xy, dxy, axis, xa, ya, labelOrientat
242239
'rotate(' + orientation.angle + ') ' +
243240
'translate(0,' + offset + ')'
244241
)
242+
.classed('user-select-none', true)
245243
.attr('text-anchor', 'middle')
246244
.call(Drawing.font, axis.title.font);
247245
});

‎src/traces/contour/plot.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,6 @@ function makeLinesAndLabels(plotgroup, pathinfo, gd, cd0, contours) {
228228
labelGroup.exit().remove();
229229

230230
labelGroup.enter().append('g')
231-
.classed('user-select-none', true)
232231
.classed('contourlabels', true);
233232

234233
if(showLabels) {

‎src/traces/contourcarpet/plot.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,6 @@ function makeLinesAndLabels(plotgroup, pathinfo, gd, cd0, contours, plotinfo, ca
161161
labelGroup.exit().remove();
162162

163163
labelGroup.enter().append('g')
164-
.classed('user-select-none', true)
165164
.classed('contourlabels', true);
166165

167166
if(showLabels) {

‎src/traces/funnelarea/plot.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,6 @@ module.exports = function plot(gd, cdModule) {
8989
.data(pt.text && (textPosition !== 'none') ? [0] : []);
9090

9191
sliceTextGroup.enter().append('g')
92-
.classed('user-select-none', true)
9392
.classed('slicetext', true);
9493
sliceTextGroup.exit().remove();
9594

@@ -142,7 +141,6 @@ module.exports = function plot(gd, cdModule) {
142141
.data(trace.title.text ? [0] : []);
143142

144143
titleTextGroup.enter().append('g')
145-
.classed('user-select-none', true)
146144
.classed('titletext', true);
147145
titleTextGroup.exit().remove();
148146

‎src/traces/parcats/parcats.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,6 @@ function performPlot(parcatsModels, graphDiv, layout, svg) {
225225

226226
// Initialize category label
227227
categoryGroupEnterSelection
228-
.classed('user-select-none', true)
229228
.append('text')
230229
.attr('class', 'catlabel')
231230
.attr('pointer-events', 'none');

‎src/traces/pie/plot.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,6 @@ function plot(gd, cdModule) {
140140
.data(pt.text && (textPosition !== 'none') ? [0] : []);
141141

142142
sliceTextGroup.enter().append('g')
143-
.classed('user-select-none', true)
144143
.classed('slicetext', true);
145144
sliceTextGroup.exit().remove();
146145

@@ -213,7 +212,6 @@ function plot(gd, cdModule) {
213212
.data(trace.title.text ? [0] : []);
214213

215214
titleTextGroup.enter().append('g')
216-
.classed('user-select-none', true)
217215
.classed('titletext', true);
218216
titleTextGroup.exit().remove();
219217

‎src/traces/scatter/plot.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -470,10 +470,7 @@ function plotOne(gd, idx, plotinfo, cdscatter, cdscatterAll, element, transition
470470

471471
// each text needs to go in its own 'g' in case
472472
// it gets converted to mathjax
473-
join.enter().append('g')
474-
.classed('user-select-none', true)
475-
.classed('textpoint', true)
476-
.append('text');
473+
join.enter().append('g').classed('textpoint', true).append('text');
477474

478475
join.order();
479476

‎src/traces/scattergeo/plot.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,7 @@ var style = require('./style');
2323

2424
function plot(gd, geo, calcData) {
2525
var scatterLayer = geo.layers.frontplot.select('.scatterlayer');
26-
var gTraces = Lib.makeTraceGroups(scatterLayer, calcData, 'trace scattergeo')
27-
.classed('user-select-none', true);
26+
var gTraces = Lib.makeTraceGroups(scatterLayer, calcData, 'trace scattergeo');
2827

2928
function removeBADNUM(d, node) {
3029
if(d.lonlat[0] === BADNUM) {

‎src/traces/sunburst/plot.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -254,9 +254,7 @@ function plotOne(gd, cd, element, transitionOpts) {
254254

255255
slicePath.call(styleOne, pt, trace);
256256

257-
var sliceTextGroup = Lib.ensureSingle(sliceTop, 'g', 'slicetext')
258-
.classed('user-select-none', true);
259-
257+
var sliceTextGroup = Lib.ensureSingle(sliceTop, 'g', 'slicetext');
260258
var sliceText = Lib.ensureSingle(sliceTextGroup, 'text', '', function(s) {
261259
// prohibit tex interpretation until we can handle
262260
// tex and regular text together

‎src/traces/treemap/draw_ancestors.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -134,9 +134,7 @@ module.exports = function drawAncestors(gd, cd, entry, slices, opts) {
134134

135135
pt._text = (helpers.getPtLabel(pt) || '').split('<br>').join(' ') || '';
136136

137-
var sliceTextGroup = Lib.ensureSingle(sliceTop, 'g', 'slicetext')
138-
.classed('user-select-none', true);
139-
137+
var sliceTextGroup = Lib.ensureSingle(sliceTop, 'g', 'slicetext');
140138
var sliceText = Lib.ensureSingle(sliceTextGroup, 'text', '', function(s) {
141139
// prohibit tex interpretation until we can handle
142140
// tex and regular text together

‎src/traces/treemap/draw_descendants.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -175,9 +175,7 @@ module.exports = function drawDescendants(gd, cd, entry, slices, opts) {
175175
}
176176
}
177177

178-
var sliceTextGroup = Lib.ensureSingle(sliceTop, 'g', 'slicetext')
179-
.classed('user-select-none', true);
180-
178+
var sliceTextGroup = Lib.ensureSingle(sliceTop, 'g', 'slicetext');
181179
var sliceText = Lib.ensureSingle(sliceTextGroup, 'text', '', function(s) {
182180
// prohibit tex interpretation until we can handle
183181
// tex and regular text together

0 commit comments

Comments
 (0)