Skip to content

Commit 4d831e2

Browse files
committed
Merge remote-tracking branch 'origin/master' into fix5292-unified-hover
2 parents 900ded3 + e3b8709 commit 4d831e2

17 files changed

+287
-187
lines changed

package-lock.json

+3-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/components/fx/hover.js

+7-6
Original file line numberDiff line numberDiff line change
@@ -1029,10 +1029,10 @@ function createHoverText(hoverData, opts, gd) {
10291029
};
10301030
var mockLayoutOut = {};
10311031
legendSupplyDefaults(mockLayoutIn, mockLayoutOut, gd._fullData);
1032-
var legendOpts = mockLayoutOut.legend;
1032+
var mockLegend = mockLayoutOut.legend;
10331033

10341034
// prepare items for the legend
1035-
legendOpts.entries = [];
1035+
mockLegend.entries = [];
10361036
for(var j = 0; j < hoverData.length; j++) {
10371037
var texts = getHoverLabelText(hoverData[j], true, hovermode, fullLayout, t0);
10381038
var text = texts[0];
@@ -1058,13 +1058,14 @@ function createHoverText(hoverData, opts, gd) {
10581058
}
10591059
pt._distinct = true;
10601060

1061-
legendOpts.entries.push([pt]);
1061+
mockLegend.entries.push([pt]);
10621062
}
1063-
legendOpts.entries.sort(function(a, b) { return a[0].trace.index - b[0].trace.index;});
1064-
legendOpts.layer = container;
1063+
mockLegend.entries.sort(function(a, b) { return a[0].trace.index - b[0].trace.index;});
1064+
mockLegend.layer = container;
10651065

10661066
// Draw unified hover label
1067-
legendDraw(gd, legendOpts);
1067+
mockLegend._inHover = true;
1068+
legendDraw(gd, mockLegend);
10681069

10691070
// Position the hover
10701071
var ly = Lib.mean(hoverData.map(function(c) {return (c.y0 + c.y1) / 2;}));

0 commit comments

Comments
 (0)