heatmap: handle categorical axis sorting except for (contour)carpet

antoinerg · antoinerg · commit 6b065160b81a · 2019-05-02T13:48:36.000-04:00
diff --git a/src/traces/heatmap/clean_2d_array.js b/src/traces/heatmap/clean_2d_array.js
@@ -32,12 +32,12 @@ module.exports = function clean2dArray(zOld, transpose, trace, xa, ya) {
 
     var xMap = function(i) {return i;};
     var yMap = function(i) {return i;};
-    if(trace && trace.type === 'heatmap') {
+    if(trace && trace.type !== 'carpet' && trace.type !== 'contourcarpet') {
         if(ya && ya.type === 'category') {
-            yMap = function(i) {return trace._y[i];};
+            if(trace._y.length) yMap = function(i) {return trace._y[i];};
         }
         if(xa && xa.type === 'category') {
-            xMap = function(i) {return trace._x[i];};
+            if(trace._x.length) xMap = function(i) {return trace._x[i];};
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -32,12 +32,12 @@ module.exports = function clean2dArray(zOld, transpose, trace, xa, ya) {`
`32`	`32`
`33`	`33`	`var xMap = function(i) {return i;};`
`34`	`34`	`var yMap = function(i) {return i;};`
`35`		`- if(trace && trace.type === 'heatmap') {`
	`35`	`+ if(trace && trace.type !== 'carpet' && trace.type !== 'contourcarpet') {`
`36`	`36`	`if(ya && ya.type === 'category') {`
`37`		`- yMap = function(i) {return trace._y[i];};`
	`37`	`+ if(trace._y.length) yMap = function(i) {return trace._y[i];};`
`38`	`38`	`}`
`39`	`39`	`if(xa && xa.type === 'category') {`
`40`		`- xMap = function(i) {return trace._x[i];};`
	`40`	`+ if(trace._x.length) xMap = function(i) {return trace._x[i];};`
`41`	`41`	`}`
`42`	`42`	`}`
`43`	`43`