Skip to content

Commit 9e6b488

Browse files
committed
cleanup places that pass noHover: true to handleTickLabelDefaults
... as hoverformat is no longer coerced there, making this option obsolete!
1 parent 1feeac7 commit 9e6b488

File tree

3 files changed

+4
-10
lines changed

3 files changed

+4
-10
lines changed

src/components/colorbar/defaults.js

+3-5
Original file line numberDiff line numberDiff line change
@@ -53,11 +53,9 @@ module.exports = function colorbarDefaults(containerIn, containerOut, layout) {
5353

5454
handleTickValueDefaults(colorbarIn, colorbarOut, coerce, 'linear');
5555

56-
handleTickLabelDefaults(colorbarIn, colorbarOut, coerce, 'linear',
57-
{outerTicks: false, font: layout.font, noHover: true});
58-
59-
handleTickMarkDefaults(colorbarIn, colorbarOut, coerce, 'linear',
60-
{outerTicks: false, font: layout.font, noHover: true});
56+
var opts = {outerTicks: false, font: layout.font};
57+
handleTickLabelDefaults(colorbarIn, colorbarOut, coerce, 'linear', opts);
58+
handleTickMarkDefaults(colorbarIn, colorbarOut, coerce, 'linear', opts);
6159

6260
coerce('title', layout._dfltTitle.colorbar);
6361
Lib.coerceFont(coerce, 'titlefont', layout.font);

src/plots/ternary/layout/axis_defaults.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,7 @@ module.exports = function supplyLayoutDefaults(containerIn, containerOut, option
4444
coerce('min');
4545

4646
handleTickValueDefaults(containerIn, containerOut, coerce, 'linear');
47-
handleTickLabelDefaults(containerIn, containerOut, coerce, 'linear',
48-
{ noHover: false });
47+
handleTickLabelDefaults(containerIn, containerOut, coerce, 'linear', {});
4948
handleTickMarkDefaults(containerIn, containerOut, coerce,
5049
{ outerTicks: true });
5150

src/traces/carpet/axis_defaults.js

-3
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ var autoType = require('../../plots/cartesian/axis_autotype');
2929
* font: the default font to inherit
3030
* outerTicks: boolean, should ticks default to outside?
3131
* showGrid: boolean, should gridlines be shown by default?
32-
* noHover: boolean, this axis doesn't support hover effects?
3332
* data: the plot data to use in choosing auto type
3433
* bgColor: the plot background color, to calculate default gridline colors
3534
*/
@@ -38,8 +37,6 @@ module.exports = function handleAxisDefaults(containerIn, containerOut, options)
3837
font = options.font || {},
3938
attributes = carpetAttrs[letter + 'axis'];
4039

41-
options.noHover = true;
42-
4340
function coerce(attr, dflt) {
4441
return Lib.coerce(containerIn, containerOut, attributes, attr, dflt);
4542
}

0 commit comments

Comments
 (0)