Skip to content

Commit ba48115

Browse files
committed
fixup histogram & histogram2d hover
1 parent 94a164e commit ba48115

File tree

2 files changed

+18
-6
lines changed

2 files changed

+18
-6
lines changed

src/traces/histogram/hover.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,12 @@ module.exports = function hoverPoints(pointData, xval, yval, hovermode) {
2626
var posLetter = trace.orientation === 'h' ? 'y' : 'x';
2727
var pp = instanceOrPeriod(pointData, trace, posLetter);
2828
var ax = pointData[posLetter + 'a'];
29-
var label = hoverLabelText(ax, di.ph0, di.ph1);
30-
if(pp[1] !== undefined) label += ' - ' + hoverLabelText(ax, pp[0], pp[1]);
29+
var label;
30+
if(pp[1] !== undefined) {
31+
label = hoverLabelText(ax, pp[0], pp[1]);
32+
} else {
33+
label = hoverLabelText(ax, di.ph0, di.ph1);
34+
}
3135
pointData[posLetter + 'Label'] = label;
3236
}
3337

src/traces/histogram2d/hover.js

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,16 +31,24 @@ module.exports = function hoverPoints(pointData, xval, yval, hovermode, hoverLay
3131
var x1 = xRange[1];
3232
var xx = instanceOrPeriod(pointData, trace, 'x');
3333
var xa = pointData.xa;
34-
var xLabel = hoverLabelText(xa, x0, x1);
35-
if(xx[1] !== undefined) xLabel = hoverLabelText(xa, xx[0], xx[1]);
34+
var xLabel;
35+
if(xx[1] !== undefined) {
36+
xLabel = hoverLabelText(xa, xx[0], xx[1]);
37+
} else {
38+
xLabel = hoverLabelText(xa, x0, x1);
39+
}
3640
pointData.xLabel = xLabel;
3741

3842
var y0 = yRange[0];
3943
var y1 = yRange[1];
4044
var yy = instanceOrPeriod(pointData, trace, 'y');
4145
var ya = pointData.ya;
42-
var yLabel = hoverLabelText(ya, y0, y1);
43-
if(yy[1] !== undefined) yLabel = hoverLabelText(ya, yy[0], yy[1]);
46+
var yLabel;
47+
if(yy[1] !== undefined) {
48+
yLabel = hoverLabelText(ya, yy[0], yy[1]);
49+
} else {
50+
yLabel = hoverLabelText(ya, y0, y1);
51+
}
4452
pointData.yLabel = yLabel;
4553

4654
return pts;

0 commit comments

Comments
 (0)