Skip to content

Commit 3fdb43f

Browse files
Merge pull request #3690 from BjoernLudwigPTB/refactor_DataFrame_appends_to_concats
refactor pandas df.append to pd.concat w/ asserts
2 parents b5c4ce2 + 5da2df7 commit 3fdb43f

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

packages/python/plotly/plotly/express/_core.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1634,7 +1634,7 @@ def aggfunc_continuous(x):
16341634
df_tree["parent"] = df_tree["parent"].str.rstrip("/")
16351635
if cols:
16361636
df_tree[cols] = dfg[cols]
1637-
df_all_trees = df_all_trees.append(df_tree, ignore_index=True)
1637+
df_all_trees = pd.concat([df_all_trees, df_tree], ignore_index=True)
16381638

16391639
# we want to make sure than (?) is the first color of the sequence
16401640
if args["color"] and discrete_color:

packages/python/plotly/plotly/figure_factory/_county_choropleth.py

+5-5
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ def _create_us_counties_df(st_to_state_name_dict, state_to_st_dict):
8686
columns=["State", "ST", "geometry", "FIPS", "STATEFP", "NAME"],
8787
index=[max(gdf.index) + 1],
8888
)
89-
gdf = gdf.append(singlerow, sort=True)
89+
gdf = pd.concat([gdf, singlerow], sort=True)
9090

9191
f = 51515
9292
singlerow = pd.DataFrame(
@@ -103,7 +103,7 @@ def _create_us_counties_df(st_to_state_name_dict, state_to_st_dict):
103103
columns=["State", "ST", "geometry", "FIPS", "STATEFP", "NAME"],
104104
index=[max(gdf.index) + 1],
105105
)
106-
gdf = gdf.append(singlerow, sort=True)
106+
gdf = pd.concat([gdf, singlerow], sort=True)
107107

108108
f = 2270
109109
singlerow = pd.DataFrame(
@@ -120,19 +120,19 @@ def _create_us_counties_df(st_to_state_name_dict, state_to_st_dict):
120120
columns=["State", "ST", "geometry", "FIPS", "STATEFP", "NAME"],
121121
index=[max(gdf.index) + 1],
122122
)
123-
gdf = gdf.append(singlerow, sort=True)
123+
gdf = pd.concat([gdf, singlerow], sort=True)
124124

125125
row_2198 = gdf[gdf["FIPS"] == 2198]
126126
row_2198.index = [max(gdf.index) + 1]
127127
row_2198.loc[row_2198.index[0], "FIPS"] = 2201
128128
row_2198.loc[row_2198.index[0], "STATEFP"] = "02"
129-
gdf = gdf.append(row_2198, sort=True)
129+
gdf = pd.concat([gdf, row_2198], sort=True)
130130

131131
row_2105 = gdf[gdf["FIPS"] == 2105]
132132
row_2105.index = [max(gdf.index) + 1]
133133
row_2105.loc[row_2105.index[0], "FIPS"] = 2232
134134
row_2105.loc[row_2105.index[0], "STATEFP"] = "02"
135-
gdf = gdf.append(row_2105, sort=True)
135+
gdf = pd.concat([gdf, row_2105], sort=True)
136136
gdf = gdf.rename(columns={"NAME": "COUNTY_NAME"})
137137

138138
gdf_reduced = gdf[["FIPS", "STATEFP", "COUNTY_NAME", "geometry"]]

0 commit comments

Comments
 (0)