Skip to content

add traitlets as a dependency in configuration files? #3476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yuluc123 opened this issue Nov 17, 2021 · 2 comments
Open

add traitlets as a dependency in configuration files? #3476

yuluc123 opened this issue Nov 17, 2021 · 2 comments
Labels
feature something new P3 backlog

Comments

@yuluc123
Copy link

Hi
I notice that traitlets are used as direct dependency in source code file-packages/python/plotly/plotly/basewidget.py
. But traitlets is not listed in any configuration file. So I am wondering if traitlets should be listed in configuration files such as setup.py.

@nicolaskruchten
Copy link
Contributor

To use the FigureWidget one needs to install ipywidget which depends on traitlets. ipywidgets is not a hard dependency of this library because lots of folks don't use FigureWidget :)

@yuluc123
Copy link
Author

Thanks for your reply.
But I think even traitlets is not hardcore dependency, maybe it should be introduced as an extra dependnecy for the project.
Maybe it can be listed in extra requirements.txt in the sub-folders?

@gvwilson gvwilson self-assigned this Jun 26, 2024
@gvwilson gvwilson removed their assignment Aug 2, 2024
@gvwilson gvwilson added the P3 backlog label Aug 12, 2024
@gvwilson gvwilson changed the title should traitlets be listed as a dependency in configuration files? add traitlets as a dependency in configuration files? Aug 12, 2024
@gvwilson gvwilson added the feature something new label Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature something new P3 backlog
Projects
None yet
Development

No branches or pull requests

3 participants