Skip to content

Make .width method of Bar to be Option<f64> #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
andrei-ng opened this issue Aug 26, 2024 · 2 comments
Closed

Make .width method of Bar to be Option<f64> #229

andrei-ng opened this issue Aug 26, 2024 · 2 comments
Labels
good first issue Good for newcomers

Comments

@andrei-ng
Copy link
Collaborator

Reported by @Ionizing in #141

The .width method of Bar is Option<usize>, while it is a float number in plotly.js. In some situation, we may need to display bar chart within a curve plot like this ...

and it's useful to let user specify a proper barwidth to show well.
@andrei-ng andrei-ng added the good first issue Good for newcomers label Aug 26, 2024
@andrei-ng
Copy link
Collaborator Author

@Ionizing could you submit a PR with your fork / fix

@Ionizing Ionizing mentioned this issue Aug 27, 2024
Merged
@andrei-ng
Copy link
Collaborator Author

Fixed in #230

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andrei-ng