Auth basic: fixed file descriptor leak on memory allocation error.

pluknet · pluknet · commit 034f15bbc251 · 2025-08-11T20:57:47.000+04:00
Found by Coverity (CID 1662016).
diff --git a/src/http/modules/ngx_http_auth_basic_module.c b/src/http/modules/ngx_http_auth_basic_module.c
@@ -253,7 +253,8 @@ ngx_http_auth_basic_handler(ngx_http_request_t *r)
         pwd.len = i - passwd;
         pwd.data = ngx_pnalloc(r->pool, pwd.len + 1);
         if (pwd.data == NULL) {
-            return NGX_HTTP_INTERNAL_SERVER_ERROR;
+            rc = NGX_HTTP_INTERNAL_SERVER_ERROR;
+            goto cleanup;
         }
 
         ngx_cpystrn(pwd.data, &buf[passwd], pwd.len + 1);

Original file line number	Diff line number	Diff line change
`@@ -253,7 +253,8 @@ ngx_http_auth_basic_handler(ngx_http_request_t *r)`
`253`	`253`	`pwd.len = i - passwd;`
`254`	`254`	`pwd.data = ngx_pnalloc(r->pool, pwd.len + 1);`
`255`	`255`	`if (pwd.data == NULL) {`
`256`		`- return NGX_HTTP_INTERNAL_SERVER_ERROR;`
	`256`	`+ rc = NGX_HTTP_INTERNAL_SERVER_ERROR;`
	`257`	`+ goto cleanup;`
`257`	`258`	`}`
`258`	`259`
`259`	`260`	`ngx_cpystrn(pwd.data, &buf[passwd], pwd.len + 1);`