Skip to content

Commit fd371fe

Browse files
committed
fix: "useSpring" function argument
When a function is passed to useSpring (and the "deps" argument is undefined), it should never be called more than once. Reported by: https://github.com/react-spring/react-spring/pull/852\#issuecomment-552581098
1 parent 0e02c94 commit fd371fe

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

packages/core/src/useSpring.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,10 @@ export function useSpring<Props extends UnknownProps>(
6363
/** @internal */
6464
export function useSpring(props: any, deps?: any[]): any {
6565
const isFn = is.fun(props)
66-
const [[values], update, stop] = useSprings(1, isFn ? props : [props], deps)
66+
const [[values], update, stop] = useSprings(
67+
1,
68+
isFn ? props : [props],
69+
isFn ? deps || [] : deps
70+
)
6771
return isFn || arguments.length == 2 ? [values, update, stop] : values
6872
}

0 commit comments

Comments
 (0)