Skip to content

v9 UseTransitionProps Type should implement ref property. #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TimoP opened this issue Sep 5, 2019 · 2 comments
Closed

v9 UseTransitionProps Type should implement ref property. #803

TimoP opened this issue Sep 5, 2019 · 2 comments
Labels
area: typescript Typescript issues kind: bug Something isn't working

Comments

@TimoP
Copy link

TimoP commented Sep 5, 2019

🐛 Bug Report

If i use UseTransitionProps to create an useTransition config incl. ref than TS is complaining that ref is not part of UseTransitionProps. I take a look at the types an ref is realy not part of UseTransitionProps. If i put the config directly in the useTransition() hook than no error is appearing because of the UnknownProps extendtion direct in function declaration.

image

To Reproduce

Use UseTransitionProps type and set ref.

Expected behavior

ref should be part of UseTransitionProps type.

Link to repro (highly encouraged)

CodeSandbox demo

Environment

  • react-spring v9.0.0-beta.34
  • react v16.8.4
  • typescript v3.3.3
@TimoP TimoP added the kind: bug Something isn't working label Sep 5, 2019
@TimoP
Copy link
Author

TimoP commented Sep 6, 2019

Updated with more information and added the bug report layout.

@aleclarson aleclarson added the area: typescript Typescript issues label Sep 6, 2019
@aleclarson
Copy link
Contributor

This is fixed in #809

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: typescript Typescript issues kind: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants