Skip to content

[ENH]: Allow configuration of environment variables #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mrsimonemms opened this issue Nov 29, 2024 · 0 comments · May be fixed by #17
Open

[ENH]: Allow configuration of environment variables #16

mrsimonemms opened this issue Nov 29, 2024 · 0 comments · May be fixed by #17
Labels
enhancement New feature or request

Comments

@mrsimonemms
Copy link

Description

Thanks for this chart, it works well. I'd like to move the GOTIFY_DEFAULTUSER_NAME and GOTIFY_DEFAULTUSER_PASS into a secret.

My suggestion is to wrap these in an if statement and then have an additionalEnvVars array of objects that can be used. This then would have something like this in the configuration:

additionalEnvVars:
  - name: GOTIFY_DEFAULTUSER_NAME
    valueFrom:
      secretKeyRef:
        name: some-secret
        key: username
  - name: GOTIFY_DEFAULTUSER_PASS
    valueFrom:
      secretKeyRef:
        name: some-secret
        key: password

Additional Information

Will raise a PR for this

@mrsimonemms mrsimonemms added the enhancement New feature or request label Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant