Deprecate Store.scope(state:) for view store observe (#2097)

* Deprecate `Store.scope(state:)` for view store `observe`

Explicit scoping is most appropriate for transforming domains, which
almost always requires an action transform. In the rare case it doesn't,
we should prefer an explicit `{ $0 }`.

Scoping for the view has been deprecated for awhile for the `observe`
parameter when creating view stores, so let's lead folks that direction.

* wip

* wip

Author: stephencelis

Examples/CaseStudies/SwiftUICaseStudies/01-GettingStarted-AlertsAndConfirmationDialogs.swift

@@ -112,11 +112,11 @@ struct AlertAndConfirmationDialogView: View {
     }
     .navigationTitle("Alerts & Dialogs")
     .alert(
-      self.store.scope(state: \.alert),
+      self.store.scope(state: \.alert, action: { $0 }),
       dismiss: .alertDismissed
     )
     .confirmationDialog(
-      self.store.scope(state: \.confirmationDialog),
+      self.store.scope(state: \.confirmationDialog, action: { $0 }),
       dismiss: .confirmationDialogDismissed
     )
   }

Examples/CaseStudies/SwiftUICaseStudies/01-GettingStarted-Animations.swift

@@ -139,7 +139,7 @@ struct AnimationsView: View {
         Button("Reset") { viewStore.send(.resetButtonTapped) }
           .padding([.horizontal, .bottom])
       }
-      .alert(self.store.scope(state: \.alert), dismiss: .alertDismissed)
+      .alert(self.store.scope(state: \.alert, action: { $0 }), dismiss: .alertDismissed)
       .navigationBarTitleDisplayMode(.inline)
     }
   }

Examples/CaseStudies/SwiftUICaseStudies/01-GettingStarted-SharedState.swift

@@ -218,7 +218,7 @@ struct SharedStateCounterView: View {
       }
       .padding(.top)
       .navigationTitle("Shared State Demo")
-      .alert(self.store.scope(state: \.alert), dismiss: .alertDismissed)
+      .alert(self.store.scope(state: \.alert, action: { $0 }), dismiss: .alertDismissed)
     }
   }
 }

Examples/CaseStudies/SwiftUICaseStudies/02-Effects-WebSocket.swift

@@ -180,7 +180,7 @@ struct WebSocketView: View {
           Text("Received messages")
         }
       }
-      .alert(self.store.scope(state: \.alert), dismiss: .alertDismissed)
+      .alert(self.store.scope(state: \.alert, action: { $0 }), dismiss: .alertDismissed)
       .navigationTitle("Web Socket")
     }
   }

Examples/CaseStudies/SwiftUICaseStudies/04-HigherOrderReducers-ReusableFavoriting.swift

@@ -77,7 +77,7 @@ struct FavoriteButton<ID: Hashable & Sendable>: View {
         Image(systemName: "heart")
           .symbolVariant(viewStore.isFavorite ? .fill : .none)
       }
-      .alert(self.store.scope(state: \.alert), dismiss: .alertDismissed)
+      .alert(self.store.scope(state: \.alert, action: { $0 }), dismiss: .alertDismissed)
     }
   }
 }

Examples/SpeechRecognition/SpeechRecognition/SpeechRecognition.swift

@@ -141,7 +141,10 @@ struct SpeechRecognitionView: View {
         }
       }
       .padding()
-      .alert(self.store.scope(state: \.alert), dismiss: .authorizationStateAlertDismissed)
+      .alert(
+        self.store.scope(state: \.alert, action: { $0 }),
+        dismiss: .authorizationStateAlertDismissed
+      )
     }
   }
 }

Examples/TicTacToe/tic-tac-toe/Sources/GameUIKit/GameViewController.swift

@@ -29,7 +29,7 @@ public final class GameViewController: UIViewController {
 
   public init(store: StoreOf<Game>) {
     self.store = store
-    self.viewStore = ViewStore(store.scope(state: ViewState.init))
+    self.viewStore = ViewStore(store, observe: ViewState.init)
     super.init(nibName: nil, bundle: nil)
   }
 

Examples/TicTacToe/tic-tac-toe/Sources/LoginSwiftUI/LoginView.swift

@@ -95,7 +95,7 @@ public struct LoginView: View {
         .disabled(viewStore.isLoginButtonDisabled)
       }
       .disabled(viewStore.isFormDisabled)
-      .alert(self.store.scope(state: \.alert), dismiss: .alertDismissed)
+      .alert(self.store.scope(state: \.alert, action: { $0 }), dismiss: .alertDismissed)
     }
     .navigationTitle("Login")
   }

Examples/TicTacToe/tic-tac-toe/Sources/LoginUIKit/LoginViewController.swift

@@ -40,7 +40,7 @@ public class LoginViewController: UIViewController {
 
   public init(store: StoreOf<Login>) {
     self.store = store
-    self.viewStore = ViewStore(store.scope(state: ViewState.init, action: Login.Action.init))
+    self.viewStore = ViewStore(store, observe: ViewState.init, send: Login.Action.init)
     super.init(nibName: nil, bundle: nil)
   }
 

Examples/TicTacToe/tic-tac-toe/Sources/NewGameUIKit/NewGameViewController.swift

@@ -33,7 +33,7 @@ public class NewGameViewController: UIViewController {
 
   public init(store: StoreOf<NewGame>) {
     self.store = store
-    self.viewStore = ViewStore(store.scope(state: ViewState.init, action: NewGame.Action.init))
+    self.viewStore = ViewStore(store, observe: ViewState.init, send: NewGame.Action.init)
     super.init(nibName: nil, bundle: nil)
   }