Skip to content

Commit c5ee92e

Browse files
takaswiemarcelocerri
authored andcommitted
ALSA: oxfw: fix return value in error path of isochronous resources reservation
BugLink: https://bugs.launchpad.net/bugs/1856869 commit 59a126a upstream. Even if isochronous resources reservation fails, error code doesn't return in pcm.hw_params callback. Cc: <[email protected]> #5.3+ Fixes: 4f380d0 ("ALSA: oxfw: configure packet format in pcm.hw_params callback") Signed-off-by: Takashi Sakamoto <[email protected]> Link: https://lore.kernel.org/r/20191209151655.GA8090@workstation Signed-off-by: Takashi Iwai <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]> Signed-off-by: Connor Kuehl <[email protected]> Signed-off-by: Kleber Sacilotto de Souza <[email protected]>
1 parent 9762280 commit c5ee92e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

sound/firewire/oxfw/oxfw-pcm.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,7 @@ static int pcm_playback_hw_params(struct snd_pcm_substream *substream,
255255
mutex_unlock(&oxfw->mutex);
256256
}
257257

258-
return 0;
258+
return err;
259259
}
260260

261261
static int pcm_capture_hw_free(struct snd_pcm_substream *substream)

0 commit comments

Comments
 (0)