Typing for .subscribe()/publication API is not defined

[oOBoomberOo]

No description provided.

[porsager]

If you want to make a PR for this that would be appreciated 😉

cc @Minigugus

[oOBoomberOo]

I do want to, but I'm afraid I'm not used to the codebase yet; combined with the lack of documentation around the feature, I'm just not sure what its types are supposed to be.
Hopefully, someone who better understands the API can teach me/write the PR themselves.

[Minigugus]

@oOBoomberOo The #257 PR already added publication API types to the rewrite branch, for the v3 version :

postgres/types/index.d.ts

Lines 363 to 385 in 43d78d5

	interface ColumnInfo {
	key: number;
	name: string;
	type: number;
	parser?(raw: string): unknown;
	atttypmod: number;
	}
	interface RelationInfo {
	schema: string;
	table: string;
	columns: ColumnInfo[];
	keys: ColumnInfo[];
	}
	type ReplicationEvent =
	| { command: 'insert', relation: RelationInfo }
	| { command: 'delete', relation: RelationInfo, key: boolean }
	| { command: 'update', relation: RelationInfo, key: boolean, old: Row | null };
	interface SubscriptionHandle {
	unsubscribe(): void;
	}

postgres/types/index.d.ts

Line 568 in 43d78d5

subscribe(event: string, cb: (row: Row | null, info: ReplicationEvent) => void): Promise<SubscriptionHandle>;

@porsager Maybe @oOBoomberOo could open another PR for a v2 backport of thoses types? I guess thoses types hasn't changed between the 2 versions, that shouldn't be complicated. What do you think @oOBoomberOo?

[porsager]

@Minigugus No I don't think that should be necessary. Better to focus on getting v3 out.