Set a timeout on running poetry CLI commands (microsoft/vscode-python#18212)

Author: Kartik Raj

extensions/positron-python/src/client/pythonEnvironments/base/info/environmentInfoService.ts

@@ -7,7 +7,7 @@ import { createRunningWorkerPool, IWorkerPool, QueuePosition } from '../../../co
 import { getInterpreterInfo, InterpreterInformation } from './interpreter';
 import { buildPythonExecInfo } from '../../exec';
 import { traceError, traceInfo } from '../../../logging';
-import { Conda, CONDA_RUN_TIMEOUT, isCondaEnvironment } from '../../common/environmentManagers/conda';
+import { Conda, CONDA_ACTIVATION_TIMEOUT, isCondaEnvironment } from '../../common/environmentManagers/conda';
 import { PythonEnvInfo, PythonEnvKind } from '.';
 import { normCasePath } from '../../common/externalDependencies';
 
@@ -41,7 +41,7 @@ async function buildEnvironmentInfoUsingCondaRun(env: PythonEnvInfo): Promise<In
     }
     const interpreterInfo = await getInterpreterInfo(
         buildPythonExecInfo(python, undefined, env.executable.filename),
-        CONDA_RUN_TIMEOUT,
+        CONDA_ACTIVATION_TIMEOUT,
     );
     return interpreterInfo;
 }

extensions/positron-python/src/client/pythonEnvironments/common/environmentManagers/conda.ts

@@ -202,7 +202,8 @@ export async function getPythonVersionFromConda(interpreterPath: string): Promis
 
 // Minimum version number of conda required to be able to use 'conda run' with '--no-capture-output' flag.
 export const CONDA_RUN_VERSION = '4.9.0';
-export const CONDA_RUN_TIMEOUT = 45000;
+export const CONDA_ACTIVATION_TIMEOUT = 45000;
+const CONDA_GENERAL_TIMEOUT = 50000;
 
 export const CONDA_RUN_SCRIPT = path.join(_SCRIPTS_DIR, 'conda_run_script.py');
 
@@ -361,7 +362,7 @@ export class Conda {
     @cache(30_000, true, 10_000)
     // eslint-disable-next-line class-methods-use-this
     private async getInfoCached(command: string): Promise<CondaInfo> {
-        const result = await exec(command, ['info', '--json'], { timeout: 50000 });
+        const result = await exec(command, ['info', '--json'], { timeout: CONDA_GENERAL_TIMEOUT });
         traceVerbose(`conda info --json: ${result.stdout}`);
         return JSON.parse(result.stdout);
     }
@@ -430,7 +431,7 @@ export class Conda {
         if (info && info.conda_version) {
             versionString = info.conda_version;
         } else {
-            const stdOut = await exec(this.command, ['--version'], { timeout: 50000 })
+            const stdOut = await exec(this.command, ['--version'], { timeout: CONDA_GENERAL_TIMEOUT })
                 .then((result) => result.stdout.trim())
                 .catch<string | undefined>(() => undefined);
 

extensions/positron-python/src/client/pythonEnvironments/common/environmentManagers/poetry.ts

@@ -84,6 +84,8 @@ export async function isPoetryEnvironment(interpreterPath: string): Promise<bool
     return false;
 }
 
+const POETRY_TIMEOUT = 50000;
+
 /** Wraps the "poetry" utility, and exposes its functionality.
  */
 export class Poetry {
@@ -262,11 +264,12 @@ export class Poetry {
 
     private async safeShellExecute(command: string, logVerbose = false) {
         // It has been observed that commands related to conda or poetry binary take upto 10-15 seconds unlike
-        // python binaries. So for now no timeouts on them.
+        // python binaries. So have a large timeout.
         const stopWatch = new StopWatch();
         const result = await shellExecute(command, {
             cwd: this.cwd,
             throwOnStdErr: true,
+            timeout: POETRY_TIMEOUT,
         }).catch((ex) => {
             if (logVerbose) {
                 traceVerbose(ex);