Merge followup

Author: schloerke

shiny/render/_display.py

@@ -100,7 +100,7 @@ async def render(self) -> JsonifiableDict | None:
         if len(results) == 0:
             return None
 
-        session = require_active_session(None)
+        session = require_active_session()
         return rendered_deps_to_jsonifiable(
             session._process_ui(
                 TagList(*results)  # pyright: ignore[reportGeneralTypeIssues]

shiny/render/_render.py

@@ -274,7 +274,7 @@ def __init__(
     async def render(self) -> dict[str, Jsonifiable] | Jsonifiable | None:
         is_userfn_async = self.fn.is_async()
         name = self.output_id
-        session = require_active_session(None)
+        session = require_active_session()
         width = self.width
         height = self.height
         alt = self.alt
@@ -586,7 +586,7 @@ def auto_output_ui(self) -> Tag:
         return _ui.output_ui(self.output_id)
 
     async def transform(self, value: TagChild) -> Jsonifiable:
-        session = require_active_session(None)
+        session = require_active_session()
         return rendered_deps_to_jsonifiable(
             session._process_ui(value),
         )
@@ -664,7 +664,7 @@ def __call__(  # pyright: ignore[reportIncompatibleMethodOverride]
         def url() -> str:
             from urllib.parse import quote
 
-            session = require_active_session(None)
+            session = require_active_session()
             return f"session/{quote(session.id)}/download/{quote(self.output_id)}?w="
 
         # Unlike most value functions, this one's name is `url`. But we want to get the

shiny/render/renderer/_renderer.py

@@ -119,7 +119,7 @@ class Renderer(Generic[IT]):
 
     This value **will not** contain a module prefix (or session name-spacing). To get
     the fully resolved ID, call
-    `shiny.session.require_active_session(None).ns(self.output_id)`.
+    `shiny.session.require_active_session().ns(self.output_id)`.
 
     An initial value of `.__name__` (set within `Renderer.__call__(_fn)`) will be used until the
     output renderer is registered within the session.
@@ -266,7 +266,7 @@ def _on_register(self) -> None:
             # (w/ module support)
             from ...session import require_active_session
 
-            session = require_active_session(None)
+            session = require_active_session()
             ns_name = session.output._ns(self.__name__)
             session.output.remove(ns_name)
             self._auto_registered = False

shiny/render/transformer/_transformer.py

@@ -276,7 +276,7 @@ def _meta(self) -> TransformerMetadata:
         """
         from ...session import require_active_session
 
-        session = require_active_session(None)
+        session = require_active_session()
         return TransformerMetadata(
             session=session,
             name=self.output_id,

tests/playwright/examples/example_apps.py

@@ -47,6 +47,11 @@ def get_apps(path: str) -> typing.List[str]:
     "ShinyDeprecationWarning:",
     "shiny.render.transformer.output_transformer()",
 ]
+session_warnings = [
+    # shinywidgets.register_widget() uses `session` when registering widget
+    "ShinyDeprecationWarning: `session=` is deprecated",
+    "session_type_warning()",  # continutation of line above
+]
 express_warnings = ["Detected Shiny Express app. "]
 app_allow_shiny_errors: typing.Dict[
     str, typing.Union[Literal[True], typing.List[str]]
@@ -60,8 +65,8 @@ def get_apps(path: str) -> typing.List[str]:
         "UserWarning: This figure includes Axes that are not compatible with tight_layout",
     ],
     # Remove after shinywidgets accepts `Renderer` PR
-    "airmass": [*output_transformer_errors],
-    "brownian": [*output_transformer_errors],
+    "airmass": [*output_transformer_errors, *session_warnings],
+    "brownian": [*output_transformer_errors, *session_warnings],
     "multi-page": [*output_transformer_errors],
     "model-score": [*output_transformer_errors],
     "data_frame": [*output_transformer_errors],