Skip to content

Commit 4b40b9a

Browse files
authored
Fix failing express tests (#887)
1 parent 711b1af commit 4b40b9a

File tree

3 files changed

+7
-4
lines changed

3 files changed

+7
-4
lines changed

Makefile

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,13 +94,16 @@ install-playwright:
9494
install-trcli:
9595
which trcli || pip install trcli
9696

97+
install-rsconnect: ## install the main version of rsconnect till pypi version supports shiny express
98+
pip install git+https://github.com/rstudio/rsconnect-python.git#egg=rsconnect-python
99+
97100
playwright-shiny: install-playwright ## end-to-end tests with playwright
98101
pytest tests/playwright/shiny/$(SUB_FILE)
99102

100103
playwright-examples: install-playwright ## end-to-end tests on examples with playwright
101104
pytest tests/playwright/examples
102105

103-
playwright-deploys: install-playwright ## end-to-end tests on deploys with playwright
106+
playwright-deploys: install-playwright install-rsconnect ## end-to-end tests on deploys with playwright
104107
pytest tests/playwright/deploys/$(SUB_FILE) -s
105108

106109
testrail-junit: install-playwright install-trcli ## end-to-end tests with playwright and generate junit report

tests/playwright/shiny/shiny-express/page_default/app.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,14 +28,14 @@
2828

2929
with layout.column(width=6):
3030
# check height is below 300px - bounding box
31-
with layout.navset_card_tab(id="express_navset_card_tab"):
31+
with layout.navset_card(id="express_navset_card_tab", type="tab"):
3232
with layout.nav(title="Two"):
3333
...
3434

3535

3636
with layout.column(width=6):
3737
with layout.row():
38-
with layout.navset_tab(id="express_navset_tab"):
38+
with layout.navset(id="express_navset_tab", type="tab"):
3939
for fn_txt, fn in [
4040
("pre", layout.pre),
4141
("div", layout.div),

tests/playwright/shiny/shiny-express/page_default/test_page_default.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,6 @@
33
from utils.express_utils import verify_express_page_default
44

55

6-
def test_express_accordion(page: Page, local_app: ShinyAppProc) -> None:
6+
def test_page_default(page: Page, local_app: ShinyAppProc) -> None:
77
page.goto(local_app.url)
88
verify_express_page_default(page)

0 commit comments

Comments
 (0)