Skip to content

Commit 8ac44de

Browse files
authored
build: set Narwhals 1.9.1 as minimum, remove upper bound, use narwhals.stable.v1 for dtypes and typing (#1717)
1 parent 3ff6567 commit 8ac44de

File tree

8 files changed

+12
-12
lines changed

8 files changed

+12
-12
lines changed

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ dependencies = [
4747
"prompt-toolkit;platform_system!='Emscripten'",
4848
"python-multipart>=0.0.7;platform_system!='Emscripten'",
4949
"setuptools;python_version>='3.12'",
50-
"narwhals>=1.9.0,<1.10.0",
50+
"narwhals>=1.9.1",
5151
"orjson>=3.10.7",
5252
]
5353

shiny/render/_data_frame_utils/_types.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,11 @@
1414

1515
import narwhals.stable.v1 as nw
1616
from htmltools import TagNode
17-
from narwhals.dtypes import DType as DType
18-
from narwhals.typing import DataFrameT as DataFrameT
19-
from narwhals.typing import IntoDataFrame as IntoDataFrame
20-
from narwhals.typing import IntoDataFrameT as IntoDataFrameT
21-
from narwhals.typing import IntoExpr as IntoExpr
17+
from narwhals.stable.v1.dtypes import DType as DType
18+
from narwhals.stable.v1.typing import DataFrameT as DataFrameT
19+
from narwhals.stable.v1.typing import IntoDataFrame as IntoDataFrame
20+
from narwhals.stable.v1.typing import IntoDataFrameT as IntoDataFrameT
21+
from narwhals.stable.v1.typing import IntoExpr as IntoExpr
2222

2323
from ..._typing_extensions import Annotated, NotRequired, Required, TypedDict
2424
from ...types import Jsonifiable, JsonifiableDict, ListOrTuple

tests/playwright/shiny/components/data_frame/data_view_info/app.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
# pyright: reportArgumentType = false
66
# pyright: reportUnknownMemberType = false
77
import polars as pl
8-
from narwhals.typing import IntoDataFrame
8+
from narwhals.stable.v1.typing import IntoDataFrame
99
from palmerpenguins import load_penguins_raw
1010

1111
from shiny import App, Inputs, Outputs, Session, module, render, ui

tests/playwright/shiny/components/data_frame/df_methods/app.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import pandas as pd
22
import polars as pl
33
import seaborn as sns
4-
from narwhals.typing import IntoDataFrame
4+
from narwhals.stable.v1.typing import IntoDataFrame
55

66
from shiny import App, Inputs, Outputs, Session, module, reactive, render, ui
77

tests/playwright/shiny/components/data_frame/row_selection/app.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
import palmerpenguins # pyright: ignore[reportMissingTypeStubs]
44
import polars as pl
5-
from narwhals.typing import IntoDataFrame
5+
from narwhals.stable.v1.typing import IntoDataFrame
66

77
from shiny import App, Inputs, Outputs, Session, module, reactive, render, ui
88

tests/playwright/shiny/components/data_frame/styles/app.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
# pyright: reportMissingTypeStubs = false
66
import palmerpenguins
77
import polars as pl
8-
from narwhals.typing import IntoDataFrame
8+
from narwhals.stable.v1.typing import IntoDataFrame
99

1010
from shiny import App, Inputs, Outputs, Session, module, render, ui
1111

tests/playwright/shiny/components/data_frame/validate_column_labels/app.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
import palmerpenguins # pyright: ignore[reportMissingTypeStubs]
66
import polars as pl
7-
from narwhals.typing import IntoDataFrame
7+
from narwhals.stable.v1.typing import IntoDataFrame
88

99
from shiny import Inputs, Outputs, Session
1010
from shiny.express import module, render, ui

tests/pytest/test_render_data_frame_tbl_data.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -341,7 +341,7 @@ def test_subset_frame_cols_single(small_df_f: IntoDataFrame):
341341
def test_dtype_coverage():
342342
from pathlib import Path
343343

344-
from narwhals import dtypes as nw_dtypes
344+
from narwhals.stable.v1 import dtypes as nw_dtypes
345345

346346
# Copy from https://github.com/narwhals-dev/narwhals/blob/2c9e2e7a308ebb30c6f672e27c1da2086ebbecbc/utils/check_api_reference.py#L144-L146
347347
dtype_names = [

0 commit comments

Comments
 (0)