Skip to content

Commit ba79975

Browse files
valyalapossibull
authored andcommitted
deployment/docker: downgrade Go builder from 1.22.0 to 1.21.7
Go1.22.0 contains the bug golang/go#65705 , which prevents vmagent from normal operation.
1 parent a0a4155 commit ba79975

38 files changed

+579
-6
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -466,7 +466,7 @@ benchmark-pure:
466466
vendor-update:
467467
go get -u -d ./lib/...
468468
go get -u -d ./app/...
469-
go mod tidy -compat=1.22
469+
go mod tidy -compat=1.21
470470
go mod vendor
471471

472472
app-local:

app/vmui/Dockerfile-web

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM golang:1.22.0 as build-web-stage
1+
FROM golang:1.21.7 as build-web-stage
22
COPY build /build
33

44
WORKDIR /build

deployment/docker/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ DOCKER_NAMESPACE ?= victoriametrics
55
ROOT_IMAGE ?= alpine:3.19.1
66
CERTS_IMAGE := alpine:3.19.1
77

8-
GO_BUILDER_IMAGE := golang:1.22.0-alpine
8+
GO_BUILDER_IMAGE := golang:1.21.7-alpine
99
BUILDER_IMAGE := local/builder:2.0.0-$(shell echo $(GO_BUILDER_IMAGE) | tr :/ __)-1
1010
BASE_IMAGE := local/base:1.1.4-$(shell echo $(ROOT_IMAGE) | tr :/ __)-$(shell echo $(CERTS_IMAGE) | tr :/ __)
1111
DOCKER ?= docker

deployment/logs-benchmark/docker-compose-elk.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ services:
1818
- vlogs
1919

2020
generator:
21-
image: golang:1.22.0-alpine
21+
image: golang:1.21.7-alpine
2222
restart: always
2323
working_dir: /go/src/app
2424
volumes:

deployment/logs-benchmark/docker-compose-loki.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ version: '3'
22

33
services:
44
generator:
5-
image: golang:1.22.0-alpine
5+
image: golang:1.21.7-alpine
66
restart: always
77
working_dir: /go/src/app
88
volumes:

docs/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ See also [LTS releases](https://docs.victoriametrics.com/LTS-releases.html).
4343
* FEATURE: [vmalert](https://docs.victoriametrics.com/#vmalert): support filtering by group, rule or labels in [vmalert's UI](https://docs.victoriametrics.com/vmalert/#web) for `/groups` and `/alerts` pages. See [the pull request](https://github.com/VictoriaMetrics/VictoriaMetrics/pull/5791) by @victoramsantos.
4444
* FEATURE: [docker-compose](https://github.com/VictoriaMetrics/VictoriaMetrics/tree/master/deployment/docker#docker-compose-environment-for-victoriametrics): create a separate [docker-compose environment](https://github.com/VictoriaMetrics/VictoriaMetrics/blob/master/deployment/docker/docker-compose-victorialogs.yml) for VictoriaLogs installation, including fluentbit and [VictoriaLogs Grafana datasource](https://github.com/VictoriaMetrics/victorialogs-datasource).
4545

46+
* BUGFIX: downgrade Go builder from `1.22.0` to `1.21.7`, since `1.22.0` contains [the bug](https://github.com/golang/go/issues/65705), which can lead to deadlocked HTTP connections to remote storage systems, scrape targets and service discovery endpoints at [vmagent](https://docs.victoriametrics.com/vmagent/). This may result in incorrect service discovery, target scraping and failed sending samples to remote storage.
4647
* BUGFIX: all VictoriaMetrics components: return back periodic closing of incoming connections to `-httpListenAddr` every 2 minutes, which was disabled in [v1.98.0](https://github.com/VictoriaMetrics/VictoriaMetrics/releases/tag/v1.98.0) when addressing [this issue](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1304#issuecomment-1636997037). See [this comment](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/1304#issuecomment-1961891450) for details on why the periodic closing of incoming connections has been returned back.
4748
* BUGFIX: [vmagent](https://docs.victoriametrics.com/vmagent.html): fix possible deadlock when [sharding among remote storages](https://docs.victoriametrics.com/vmagent/#sharding-among-remote-storages) is enabled with `-remoteWrite.shardByURL` command-line flag. Thanks to @penguinlav for [the fix](https://github.com/VictoriaMetrics/VictoriaMetrics/pull/5834) for [this issue](https://github.com/VictoriaMetrics/VictoriaMetrics/issues/5833).
4849
* BUGFIX: fix the misleading error `0ms is out of allowed range [0 ...` when passing `step=0` to [/api/v1/query](https://docs.victoriametrics.com/keyconcepts/#instant-query)

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
module github.com/VictoriaMetrics/VictoriaMetrics
22

3-
go 1.22
3+
go 1.21
44

55
// The github.com/prometheus/prometheus v0.50.0 depends on github.com/prometheus/common v0.46.0
66
// TODO: remove this replacement for the new version of github.com/prometheus/prometheus

vendor/github.com/google/s2a-go/internal/v2/remotesigner/testdata/client_cert.pem

Lines changed: 24 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/google/s2a-go/internal/v2/remotesigner/testdata/client_key.pem

Lines changed: 27 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/google/s2a-go/internal/v2/remotesigner/testdata/server_cert.pem

Lines changed: 24 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/google/s2a-go/internal/v2/remotesigner/testdata/server_key.pem

Lines changed: 27 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/google/s2a-go/internal/v2/testdata/client_cert.pem

Lines changed: 24 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/google/s2a-go/internal/v2/testdata/client_key.pem

Lines changed: 27 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/google/s2a-go/internal/v2/testdata/server_cert.pem

Lines changed: 24 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/google/s2a-go/internal/v2/testdata/server_key.pem

Lines changed: 27 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/google/s2a-go/internal/v2/tlsconfigstore/testdata/client_cert.pem

Lines changed: 24 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/google/s2a-go/internal/v2/tlsconfigstore/testdata/client_key.pem

Lines changed: 27 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)