Skip to content

CDN #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
timreichen opened this issue Jan 8, 2021 · 6 comments
Closed

CDN #3

timreichen opened this issue Jan 8, 2021 · 6 comments

Comments

@timreichen
Copy link

Not an issue, but what is the advantage of this module over using a cdn like esm.sh, jspm.dev, skypack.dev or unpkg.com?

@oscarotero
Copy link
Collaborator

Automatic conversions don't work in all cases. This is the "official" version of postcss, that use deno native dependencies (with the exception of source-map) and runs the same tests, to ensure that it does not fail.

@shadowtime2000
Copy link

Also I don't believe JSPM Skypack or Unpkg would actually work with this because it uses fs for some stuff.

@timreichen
Copy link
Author

I actually use postcss in a deno project with esm.sh. Seems to work fine as for now, so I am wondering if there is any good reason to switch to this official version for that use case.
@shadowtime2000 I am not sure if postcss really uses fs, I think some plugins do though.

@shadowtime2000
Copy link

@timreichen

I actually use postcss in a deno project with esm.sh. Seems to work fine as for now, so I am wondering if there is any good reason to switch to this official version for that use case.

CommonJS to ES conversions can be pretty buggy because of CJS's dynamic nature. As @oscarotero said, conversions like that don't always work. This gives a little more of a guarantee of stability because it is official and most likely the maintainers of PostCSS will be making sure that they stay compatible.

@shadowtime2000 I am not sure if postcss really uses fs, I think some plugins do though.

Check @oscarotero message in #1

@shadowtime2000
Copy link

Should we enable discussions on this repo then convert this to a discussion? Seems like a better way cc @oscarotero

@oscarotero
Copy link
Collaborator

@shadowtime2000 No sure about that. This repo contains only the automatic conversion of the original node postcss code. Discussions for postcss should be in the main repository. The only relevant question in this repo is why using the deno code instead jspm/esm.js and creating a discussions section for only one topic makes no sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants