Skip to content

Errors should be logged when marking a server address bad. #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
choubacha opened this issue Nov 29, 2023 · 0 comments
Open

Errors should be logged when marking a server address bad. #648

choubacha opened this issue Nov 29, 2023 · 0 comments

Comments

@choubacha
Copy link

Describe the bug
When a server address is marked bad a line is logged but it does not contain the error or reason for marking it bad. This is a bug because it makes it very difficult to troubleshoot why our connections are breaking in production. Upstream from pgcat the client appears to receive a "connection reset by peer" error but we are unable to track down the specific error.

To Reproduce
Steps to reproduce the behavior:

  1. Do something that triggers an error in the connection
  2. See the "marked bad" log line
  3. Observe that there is no line for the actual error that occurred

Expected behavior
The logged line should include at least a mention of the error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant