Skip to content

Commit 66dc4ca

Browse files
authored
Enable retry for bind tests (dotnet#37754)
1 parent 256b874 commit 66dc4ca

File tree

3 files changed

+1
-9
lines changed

3 files changed

+1
-9
lines changed

eng/test-configuration.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
{"testName": {"contains": "CheckFrebDisconnect"}},
88
{"testName": {"contains": "CheckStdoutWithLargeWrites"}},
99
{"testName": {"contains": "ServerShutsDownWhenMainExitsStress" }},
10+
{"testName": {"contains": "AddressRegistrationTests" }},
1011
{"failureMessage": "network disconnected" }
1112
],
1213
"failOnRules": [

src/Servers/IIS/IIS/test/IISExpress.FunctionalTests/InProcess/IISExpressShutdownTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ public async Task ServerShutsDownWhenMainExits()
4242

4343

4444
[ConditionalFact]
45-
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/28994")]
4645
public async Task ServerShutsDownWhenMainExitsStress()
4746
{
4847
var parameters = Fixture.GetBaseDeploymentParameters();

src/Servers/Kestrel/test/BindTests/AddressRegistrationTests.cs

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@
2929

3030
namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
3131
{
32-
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/33204")]
3332
public class AddressRegistrationTests : TestApplicationErrorLoggerLoggedTest
3433
{
3534
private const int MaxRetries = 10;
@@ -104,7 +103,6 @@ public async Task RegisterIPEndPoint_IPv6StaticPort_Success()
104103
[ConditionalTheory]
105104
[MemberData(nameof(IPEndPointRegistrationDataDynamicPort))]
106105
[IPv6SupportedCondition]
107-
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/26626")]
108106
public async Task RegisterIPEndPoint_DynamicPort_Success(IPEndPoint endPoint, string testUrl)
109107
{
110108
await RegisterIPEndPoint_Success(endPoint, testUrl);
@@ -113,7 +111,6 @@ public async Task RegisterIPEndPoint_DynamicPort_Success(IPEndPoint endPoint, st
113111
[ConditionalTheory]
114112
[MemberData(nameof(IPEndPointRegistrationDataPort443))]
115113
[IPv6SupportedCondition]
116-
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/27401")]
117114
public async Task RegisterIPEndPoint_Port443_Success(IPEndPoint endpoint, string testUrl)
118115
{
119116
if (!CanBindToEndpoint(endpoint.Address, 443))
@@ -127,7 +124,6 @@ public async Task RegisterIPEndPoint_Port443_Success(IPEndPoint endpoint, string
127124
[ConditionalTheory]
128125
[MemberData(nameof(AddressRegistrationDataIPv6))]
129126
[IPv6SupportedCondition]
130-
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/25403")]
131127
public async Task RegisterAddresses_IPv6_Success(string addressInput, string[] testUrls)
132128
{
133129
await RegisterAddresses_Success(addressInput, testUrls);
@@ -136,7 +132,6 @@ public async Task RegisterAddresses_IPv6_Success(string addressInput, string[] t
136132
[ConditionalTheory]
137133
[MemberData(nameof(AddressRegistrationDataIPv6Port5000And5001Default))]
138134
[IPv6SupportedCondition]
139-
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/27401")]
140135
public async Task RegisterAddresses_IPv6Port5000And5001Default_Success(string addressInput, string[] testUrls)
141136
{
142137
if ((!CanBindToEndpoint(IPAddress.Loopback, 5000) || !CanBindToEndpoint(IPAddress.IPv6Loopback, 5000)) &&
@@ -151,7 +146,6 @@ public async Task RegisterAddresses_IPv6Port5000And5001Default_Success(string ad
151146
[ConditionalTheory]
152147
[MemberData(nameof(AddressRegistrationDataIPv6Port80))]
153148
[IPv6SupportedCondition]
154-
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/27401")]
155149
public async Task RegisterAddresses_IPv6Port80_Success(string addressInput, string[] testUrls)
156150
{
157151
if (!CanBindToEndpoint(IPAddress.Loopback, 80) || !CanBindToEndpoint(IPAddress.IPv6Loopback, 80))
@@ -163,7 +157,6 @@ public async Task RegisterAddresses_IPv6Port80_Success(string addressInput, stri
163157
}
164158

165159
[ConditionalTheory]
166-
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/27401")]
167160
[MemberData(nameof(AddressRegistrationDataIPv6ScopeId))]
168161
[IPv6SupportedCondition]
169162
[IPv6ScopeIdPresentCondition]
@@ -743,7 +736,6 @@ public async Task DoesNotOverrideDirectConfigurationWithIServerAddressesFeature_
743736
}
744737

745738
[Fact]
746-
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/33185")]
747739
public void ThrowsWhenBindingLocalhostToIPv4AddressInUse()
748740
{
749741
ThrowsWhenBindingLocalhostToAddressInUse(AddressFamily.InterNetwork);

0 commit comments

Comments
 (0)