Skip to content

Commit a64cae1

Browse files
committed
Tint menu group divider properly
Set background color as well. Update sample menu to force group divider.
1 parent aa5f651 commit a64cae1

File tree

3 files changed

+18
-2
lines changed

3 files changed

+18
-2
lines changed

dynamic-support/src/main/java/com/pranavpandey/android/dynamic/support/theme/inflater/MenuInflaterRunnable.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,8 @@ public void run() {
8080
Dynamic.setColor(mMenu.findViewById(androidx.appcompat.R.id.icon), tintColor);
8181
Dynamic.setColor(mMenu.findViewById(androidx.appcompat.R.id.submenuarrow), tintColor);
8282
Dynamic.setColor(mMenu.findViewById(androidx.appcompat.R.id.group_divider), tintColor);
83+
Dynamic.setBackgroundColor(mMenu.findViewById(androidx.appcompat.R.id.group_divider),
84+
tintColor);
8385
Dynamic.setAlpha(mMenu.findViewById(androidx.appcompat.R.id.group_divider),
8486
Defaults.ADS_ALPHA_DIVIDER);
8587

sample/src/main/java/com/pranavpandey/android/dynamic/support/sample/fragment/WidgetsFragment.kt

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,14 @@ package com.pranavpandey.android.dynamic.support.sample.fragment
1919
import android.os.Bundle
2020
import android.text.Editable
2121
import android.text.TextWatcher
22-
import android.view.*
22+
import android.view.LayoutInflater
23+
import android.view.Menu
24+
import android.view.MenuInflater
25+
import android.view.MenuItem
26+
import android.view.View
27+
import android.view.ViewGroup
2328
import android.widget.Spinner
29+
import androidx.core.view.MenuCompat
2430
import com.pranavpandey.android.dynamic.support.adapter.DynamicSpinnerImageAdapter
2531
import com.pranavpandey.android.dynamic.support.fragment.DynamicFragment
2632
import com.pranavpandey.android.dynamic.support.listener.DynamicSearchListener
@@ -128,6 +134,8 @@ class WidgetsFragment : DynamicFragment(), DynamicSearchListener, TextWatcher {
128134

129135
// Inflate menu for this fragment.
130136
inflater.inflate(R.menu.menu_widgets, menu)
137+
// Force menu group divider.
138+
MenuCompat.setGroupDividerEnabled(menu, true)
131139
}
132140

133141
override fun onMenuItemSelected(item: MenuItem): Boolean {

sample/src/main/res/menu/menu_widgets.xml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,14 +38,20 @@
3838
android:orderInCategory="3">
3939

4040
<item
41-
android:id="@+id/menu_radio"
41+
android:id="@+id/menu_radio_one"
4242
android:title="@string/widget_radio"
4343
android:checked="true"
4444
app:showAsAction="never" />
4545

46+
<item
47+
android:id="@+id/menu_radio_two"
48+
android:title="@string/widget_radio"
49+
app:showAsAction="never" />
50+
4651
</group>
4752

4853
<group
54+
android:id="@+id/menu_group_check"
4955
android:checkableBehavior="all"
5056
android:orderInCategory="4">
5157

0 commit comments

Comments
 (0)