Skip to content

Commit 81ab5b7

Browse files
author
Benjamin E. Coe
authored
fix(v8-to-istanbul): revert off by one that broke TypeScript (bcoe#262)
1 parent df59739 commit 81ab5b7

File tree

4 files changed

+41
-41
lines changed

4 files changed

+41
-41
lines changed

‎package-lock.json

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
"istanbul-reports": "^3.0.2",
4444
"rimraf": "^3.0.0",
4545
"test-exclude": "^6.0.0",
46-
"v8-to-istanbul": "^6.0.0",
46+
"v8-to-istanbul": "^6.0.1",
4747
"yargs": "^16.0.0",
4848
"yargs-parser": "^20.0.0"
4949
},

‎test/integration.js.snap

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ exports[`c8 /* c8 ignore next */ does not incorrectly mark previous branch as un
44
",--------------|---------|----------|---------|---------|-------------------
55
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
66
--------------|---------|----------|---------|---------|-------------------
7-
All files | 100 | 100 | 100 | 100 |
8-
issue-254.js | 100 | 100 | 100 | 100 |
7+
All files | 100 | 66.67 | 100 | 100 |
8+
issue-254.js | 100 | 66.67 | 100 | 100 | 2
99
--------------|---------|----------|---------|---------|-------------------
1010
,"
1111
`;
@@ -48,9 +48,9 @@ negative
4848
-----------------|---------|----------|---------|---------|-------------------
4949
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
5050
-----------------|---------|----------|---------|---------|-------------------
51-
All files | 64.29 | 57.14 | 50 | 64.29 |
52-
ts-compiled | 78.26 | 66.67 | 100 | 78.26 |
53-
loaded.ts | 73.68 | 66.67 | 100 | 73.68 | 4-5,16-18
51+
All files | 64.29 | 66.67 | 50 | 64.29 |
52+
ts-compiled | 78.26 | 75 | 100 | 78.26 |
53+
loaded.ts | 73.68 | 71.43 | 100 | 73.68 | 4-5,16-18
5454
main.ts | 100 | 100 | 100 | 100 |
5555
ts-compiled/dir | 0 | 0 | 0 | 0 |
5656
unloaded.ts | 0 | 0 | 0 | 0 | 1-5
@@ -65,9 +65,9 @@ negative
6565
--------------|---------|----------|---------|---------|-------------------
6666
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
6767
--------------|---------|----------|---------|---------|-------------------
68-
All files | 64.29 | 57.14 | 50 | 64.29 |
69-
ts-only | 78.26 | 66.67 | 100 | 78.26 |
70-
loaded.ts | 73.68 | 66.67 | 100 | 73.68 | 4-5,16-18
68+
All files | 64.29 | 66.67 | 50 | 64.29 |
69+
ts-only | 78.26 | 75 | 100 | 78.26 |
70+
loaded.ts | 73.68 | 71.43 | 100 | 73.68 | 4-5,16-18
7171
main.ts | 100 | 100 | 100 | 100 |
7272
ts-only/dir | 0 | 0 | 0 | 0 |
7373
unloaded.ts | 0 | 0 | 0 | 0 | 1-5
@@ -336,8 +336,8 @@ a = false
336336
------------------------|---------|----------|---------|---------|-------------------
337337
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
338338
------------------------|---------|----------|---------|---------|-------------------
339-
All files | 84 | 50 | 100 | 84 |
340-
branches.typescript.ts | 84 | 50 | 100 | 84 | 7,11-12,18
339+
All files | 84 | 57.14 | 100 | 84 |
340+
branches.typescript.ts | 84 | 57.14 | 100 | 84 | 7,11-12,18
341341
------------------------|---------|----------|---------|---------|-------------------
342342
,"
343343
`;
@@ -351,8 +351,8 @@ covered
351351
-----------------------|---------|----------|---------|---------|-------------------
352352
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
353353
-----------------------|---------|----------|---------|---------|-------------------
354-
All files | 81.82 | 85.71 | 60 | 81.82 |
355-
classes.typescript.ts | 81.82 | 85.71 | 60 | 81.82 | 12-13,21-22,27-28
354+
All files | 81.82 | 87.5 | 60 | 81.82 |
355+
classes.typescript.ts | 81.82 | 87.5 | 60 | 81.82 | 12-13,21-22,27-28
356356
-----------------------|---------|----------|---------|---------|-------------------
357357
,"
358358
`;
@@ -364,8 +364,8 @@ a = false
364364
-------------|---------|----------|---------|---------|-------------------
365365
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
366366
-------------|---------|----------|---------|---------|-------------------
367-
All files | 80 | 40 | 100 | 80 |
368-
branches.js | 80 | 40 | 100 | 80 | 2,5-6,13
367+
All files | 80 | 50 | 100 | 80 |
368+
branches.js | 80 | 50 | 100 | 80 | 2,5-6,13
369369
-------------|---------|----------|---------|---------|-------------------
370370
,"
371371
`;
@@ -379,8 +379,8 @@ covered
379379
------------|---------|----------|---------|---------|-------------------
380380
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
381381
------------|---------|----------|---------|---------|-------------------
382-
All files | 85.19 | 80 | 60 | 85.19 |
383-
classes.js | 85.19 | 80 | 60 | 85.19 | 6-7,15,21
382+
All files | 85.19 | 83.33 | 60 | 85.19 |
383+
classes.js | 85.19 | 83.33 | 60 | 85.19 | 6-7,15,21
384384
------------|---------|----------|---------|---------|-------------------
385385
,"
386386
`;
@@ -402,8 +402,8 @@ a = false
402402
-------------|---------|----------|---------|---------|-------------------
403403
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
404404
-------------|---------|----------|---------|---------|-------------------
405-
All files | 80 | 40 | 100 | 80 |
406-
branches.js | 80 | 40 | 100 | 80 | 2,6-7,13
405+
All files | 80 | 55.56 | 100 | 80 |
406+
branches.js | 80 | 55.56 | 100 | 80 | 2,6-7,13
407407
-------------|---------|----------|---------|---------|-------------------
408408
,"
409409
`;
@@ -417,8 +417,8 @@ covered
417417
------------|---------|----------|---------|---------|-------------------
418418
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
419419
------------|---------|----------|---------|---------|-------------------
420-
All files | 77.78 | 83.33 | 60 | 77.78 |
421-
classes.js | 77.78 | 83.33 | 60 | 77.78 | 7-8,15-16,21-22
420+
All files | 77.78 | 80 | 71.43 | 77.78 |
421+
classes.js | 77.78 | 80 | 71.43 | 77.78 | 7-8,15-16,21-22
422422
------------|---------|----------|---------|---------|-------------------
423423
,"
424424
`;
@@ -446,9 +446,9 @@ covered
446446
------------|---------|----------|---------|---------|-------------------
447447
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
448448
------------|---------|----------|---------|---------|-------------------
449-
All files | 78.57 | 83.33 | 60 | 78.57 |
449+
All files | 78.57 | 85.71 | 60 | 78.57 |
450450
class-1.js | 100 | 100 | 100 | 100 |
451-
class-2.js | 73.91 | 83.33 | 60 | 73.91 | 7-8,15-16,21-22
451+
class-2.js | 73.91 | 85.71 | 60 | 73.91 | 7-8,15-16,21-22
452452
------------|---------|----------|---------|---------|-------------------
453453
,"
454454
`;
@@ -462,8 +462,8 @@ covered
462462
------------------|---------|----------|---------|---------|-------------------
463463
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
464464
------------------|---------|----------|---------|---------|-------------------
465-
All files | 88.24 | 85.71 | 80 | 88.24 |
466-
ts-node-basic.ts | 88.24 | 85.71 | 80 | 88.24 | 12-13,28-29
465+
All files | 88.24 | 87.5 | 80 | 88.24 |
466+
ts-node-basic.ts | 88.24 | 87.5 | 80 | 88.24 | 12-13,28-29
467467
------------------|---------|----------|---------|---------|-------------------
468468
,"
469469
`;

‎test/integration.js_10.snap

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ exports[`c8 /* c8 ignore next */ does not incorrectly mark previous branch as un
44
",--------------|---------|----------|---------|---------|-------------------
55
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
66
--------------|---------|----------|---------|---------|-------------------
7-
All files | 100 | 100 | 100 | 100 |
8-
issue-254.js | 100 | 100 | 100 | 100 |
7+
All files | 100 | 66.67 | 100 | 100 |
8+
issue-254.js | 100 | 66.67 | 100 | 100 | 2
99
--------------|---------|----------|---------|---------|-------------------
1010
,"
1111
`;
@@ -59,9 +59,9 @@ negative
5959
-----------------|---------|----------|---------|---------|-------------------
6060
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
6161
-----------------|---------|----------|---------|---------|-------------------
62-
All files | 64.29 | 57.14 | 50 | 64.29 |
63-
ts-compiled | 78.26 | 66.67 | 100 | 78.26 |
64-
loaded.ts | 73.68 | 66.67 | 100 | 73.68 | 4-5,16-18
62+
All files | 64.29 | 66.67 | 50 | 64.29 |
63+
ts-compiled | 78.26 | 75 | 100 | 78.26 |
64+
loaded.ts | 73.68 | 71.43 | 100 | 73.68 | 4-5,16-18
6565
main.ts | 100 | 100 | 100 | 100 |
6666
ts-compiled/dir | 0 | 0 | 0 | 0 |
6767
unloaded.ts | 0 | 0 | 0 | 0 | 1-5
@@ -404,8 +404,8 @@ covered
404404
-----------------------|---------|----------|---------|---------|-------------------
405405
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
406406
-----------------------|---------|----------|---------|---------|-------------------
407-
All files | 81.82 | 85.71 | 60 | 81.82 |
408-
classes.typescript.ts | 81.82 | 85.71 | 60 | 81.82 | 12-13,21-22,27-28
407+
All files | 81.82 | 87.5 | 60 | 81.82 |
408+
classes.typescript.ts | 81.82 | 87.5 | 60 | 81.82 | 12-13,21-22,27-28
409409
-----------------------|---------|----------|---------|---------|-------------------
410410
,"
411411
`;
@@ -455,8 +455,8 @@ a = false
455455
-------------|---------|----------|---------|---------|-------------------
456456
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
457457
-------------|---------|----------|---------|---------|-------------------
458-
All files | 80 | 40 | 100 | 80 |
459-
branches.js | 80 | 40 | 100 | 80 | 2,6-7,13
458+
All files | 80 | 55.56 | 100 | 80 |
459+
branches.js | 80 | 55.56 | 100 | 80 | 2,6-7,13
460460
-------------|---------|----------|---------|---------|-------------------
461461
,"
462462
`;
@@ -470,8 +470,8 @@ covered
470470
------------|---------|----------|---------|---------|-------------------
471471
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
472472
------------|---------|----------|---------|---------|-------------------
473-
All files | 77.78 | 83.33 | 60 | 77.78 |
474-
classes.js | 77.78 | 83.33 | 60 | 77.78 | 7-8,15-16,21-22
473+
All files | 77.78 | 80 | 71.43 | 77.78 |
474+
classes.js | 77.78 | 80 | 71.43 | 77.78 | 7-8,15-16,21-22
475475
------------|---------|----------|---------|---------|-------------------
476476
,"
477477
`;
@@ -499,9 +499,9 @@ covered
499499
------------|---------|----------|---------|---------|-------------------
500500
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
501501
------------|---------|----------|---------|---------|-------------------
502-
All files | 78.57 | 83.33 | 60 | 78.57 |
502+
All files | 78.57 | 85.71 | 60 | 78.57 |
503503
class-1.js | 100 | 100 | 100 | 100 |
504-
class-2.js | 73.91 | 83.33 | 60 | 73.91 | 7-8,15-16,21-22
504+
class-2.js | 73.91 | 85.71 | 60 | 73.91 | 7-8,15-16,21-22
505505
------------|---------|----------|---------|---------|-------------------
506506
,"
507507
`;

0 commit comments

Comments
 (0)