Skip to content

Commit 2ff541e

Browse files
committed
refactor: use require.resolve instead of require-relative and resolve-from
1 parent 7e740f0 commit 2ff541e

File tree

6 files changed

+14
-19
lines changed

6 files changed

+14
-19
lines changed

packages/cli/lib/lib/webpack/prerender.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ const { readFileSync } = require('fs');
44
const stackTrace = require('stack-trace');
55
const URL = require('url');
66
const { SourceMapConsumer } = require('source-map');
7-
const requireRelative = require('require-relative');
87

98
module.exports = function (env, params) {
109
params = params || {};
@@ -27,8 +26,10 @@ module.exports = function (env, params) {
2726
return '';
2827
}
2928
const { cwd } = env;
30-
const preact = require(requireRelative.resolve('preact', cwd));
31-
const renderToString = require(requireRelative.resolve('preact-render-to-string', cwd));
29+
const preact = require(require.resolve('preact', { paths: [cwd] }));
30+
const renderToString = require(require.resolve('preact-render-to-string', {
31+
paths: [cwd],
32+
}));
3233
return renderToString(preact.h(app, { ...params, url }));
3334
} catch (err) {
3435
let stack = stackTrace.parse(err).filter(s => s.getFileName() === entry)[0];

packages/cli/lib/lib/webpack/proxy-loader.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
var utils = require('loader-utils');
2-
var requireRelative = require('require-relative');
32

43
function proxyLoader(source, map) {
54
var options = utils.getOptions(this);
@@ -17,7 +16,9 @@ function proxyLoader(source, map) {
1716

1817
var loader;
1918
try {
20-
loader = requireRelative(proxyOptions.loader, proxyOptions.cwd);
19+
loader = require(require.resolve(proxyOptions.loader, {
20+
paths: [proxyOptions.cwd],
21+
}));
2122
} catch (e) {
2223
loader = require(proxyOptions.loader);
2324
}

packages/cli/lib/lib/webpack/utils.js

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
1-
const resolveFrom = require('resolve-from');
2-
31
function isInstalledVersionPreactXOrAbove(cwd) {
42
try {
53
return (
6-
parseInt(require(resolveFrom(cwd, 'preact/package.json')).version, 10) >=
7-
10
4+
parseInt(
5+
require(require.resolve('preact/package.json', { paths: [cwd] }))
6+
.version,
7+
10
8+
) >= 10
89
);
910
} catch (e) {}
1011
return false;

packages/cli/lib/lib/webpack/webpack-base-config.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ const { readFileSync, existsSync } = require('fs');
55
const { isInstalledVersionPreactXOrAbove } = require('./utils');
66
const autoprefixer = require('autoprefixer');
77
const browserslist = require('browserslist');
8-
const requireRelative = require('require-relative');
98
const MiniCssExtractPlugin = require('mini-css-extract-plugin');
109
const FixStyleOnlyEntriesPlugin = require('webpack-fix-style-only-entries');
1110
const ProgressBarPlugin = require('progress-bar-webpack-plugin');
@@ -97,12 +96,12 @@ module.exports = function (env) {
9796
let compat = 'preact-compat';
9897
try {
9998
compat = dirname(
100-
requireRelative.resolve('preact/compat/package.json', cwd)
99+
require.resolve('preact/compat/package.json', { paths: [cwd] })
101100
);
102101
} catch (e) {
103102
try {
104103
compat = dirname(
105-
requireRelative.resolve('preact-compat/package.json', cwd)
104+
require.resolve('preact-compat/package.json', { paths: [cwd] })
106105
);
107106
} catch (e) {}
108107
}

packages/cli/package.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -134,8 +134,6 @@
134134
"prompts": "^2.2.1",
135135
"raw-loader": "^4.0.0",
136136
"react-refresh": "0.8.3",
137-
"require-relative": "^0.8.7",
138-
"resolve-from": "^5.0.0",
139137
"rimraf": "^3.0.2",
140138
"sade": "^1.4.1",
141139
"size-plugin": "^2.0.1",

yarn.lock

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12366,11 +12366,6 @@ require-main-filename@^2.0.0:
1236612366
resolved "https://registry.yarnpkg.com/require-main-filename/-/require-main-filename-2.0.0.tgz#d0b329ecc7cc0f61649f62215be69af54aa8989b"
1236712367
integrity sha512-NKN5kMDylKuldxYLSUfrbo5Tuzh4hd+2E8NPPX02mZtn1VuREQToYe/ZdlJy+J3uCpfaiGF05e7B8W0iXbQHmg==
1236812368

12369-
require-relative@^0.8.7:
12370-
version "0.8.7"
12371-
resolved "https://registry.yarnpkg.com/require-relative/-/require-relative-0.8.7.tgz#7999539fc9e047a37928fa196f8e1563dabd36de"
12372-
integrity sha1-eZlTn8ngR6N5KPoZb44VY9q9Nt4=
12373-
1237412369
requires-port@^1.0.0:
1237512370
version "1.0.0"
1237612371
resolved "https://registry.yarnpkg.com/requires-port/-/requires-port-1.0.0.tgz#925d2601d39ac485e091cf0da5c6e694dc3dcaff"

0 commit comments

Comments
 (0)