From 11c5dfb61462cc537f6ed5d36f20f57a161840f0 Mon Sep 17 00:00:00 2001 From: "HIRAMATSU, Yoshifumi" Date: Fri, 15 Jan 2021 19:57:50 +0900 Subject: [PATCH 1/3] Do not produce preRenderData when --no-prerender option is specified. --- packages/cli/lib/resources/body-end.ejs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/cli/lib/resources/body-end.ejs b/packages/cli/lib/resources/body-end.ejs index be0467270..cba3b83f8 100644 --- a/packages/cli/lib/resources/body-end.ejs +++ b/packages/cli/lib/resources/body-end.ejs @@ -1,7 +1,9 @@ <%= htmlWebpackPlugin.options.ssr() %> +<% if (htmlWebpackPlugin.options.config.prerender === true) { %> +<% } %> <% if (webpack.assets.filter(entry => entry.name.match(/bundle(\.\w{5})?.esm.js$/)).length > 0) { %> <% /* Fix for safari < 11 nomodule bug. TODO: Do the following only for safari. */ %> From 888425d9498b1600e273f30863f1f7cd7194bce8 Mon Sep 17 00:00:00 2001 From: "HIRAMATSU, Yoshifumi" Date: Tue, 26 Jan 2021 17:29:47 +0900 Subject: [PATCH 2/3] Add indent. https://github.com/preactjs/preact-cli/pull/1516/files/11c5dfb61462cc537f6ed5d36f20f57a161840f0#r564133100 --- packages/cli/lib/resources/body-end.ejs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/cli/lib/resources/body-end.ejs b/packages/cli/lib/resources/body-end.ejs index cba3b83f8..7e588109a 100644 --- a/packages/cli/lib/resources/body-end.ejs +++ b/packages/cli/lib/resources/body-end.ejs @@ -1,8 +1,8 @@ <%= htmlWebpackPlugin.options.ssr() %> <% if (htmlWebpackPlugin.options.config.prerender === true) { %> - + <% } %> <% if (webpack.assets.filter(entry => entry.name.match(/bundle(\.\w{5})?.esm.js$/)).length > 0) { %> <% /* Fix for safari < 11 nomodule bug. TODO: Do the following only for safari. */ %> From 1434efa8533c60a4937d9710510a2e101a7531ef Mon Sep 17 00:00:00 2001 From: "HIRAMATSU, Yoshifumi" Date: Tue, 26 Jan 2021 17:41:52 +0900 Subject: [PATCH 3/3] Add changeset. --- .changeset/tidy-starfishes-joke.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/tidy-starfishes-joke.md diff --git a/.changeset/tidy-starfishes-joke.md b/.changeset/tidy-starfishes-joke.md new file mode 100644 index 000000000..a26b05703 --- /dev/null +++ b/.changeset/tidy-starfishes-joke.md @@ -0,0 +1,5 @@ +--- +'preact-cli': patch +--- + +Do not produce preRenderData when --no-prerender option is specified.