Skip to content

fix: restoring cache for pyproject.toml#95

Merged
pavelzw merged 10 commits into
mainfrom
fix/restoring-cache-with-pyproject-toml
Apr 11, 2024
Merged

fix: restoring cache for pyproject.toml#95
pavelzw merged 10 commits into
mainfrom
fix/restoring-cache-with-pyproject-toml

Conversation

@nichmor

@nichmor nichmor commented Apr 11, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@nichmor nichmor marked this pull request as ready for review April 11, 2024 07:07
@nichmor nichmor requested a review from pavelzw as a code owner April 11, 2024 07:07

@pavelzw pavelzw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a quick fix. In general, we should make sure, though, that setup-pixi works out of the box if only a pyproject.toml is present without specifying manifest-path.

@nichmor can you bump the patch version in package.json? Then the release pipeline will be triggered automatically once merged.

Comment thread test/pyproject-manifest/pyproject.toml Outdated
@pavelzw pavelzw added the bug Something isn't working label Apr 11, 2024
@pavelzw

pavelzw commented Apr 11, 2024

Copy link
Copy Markdown
Collaborator

Let's wait for #94 with merging, then we can release two fixes at once.

@pavelzw

pavelzw commented Apr 11, 2024

Copy link
Copy Markdown
Collaborator

Closes #93

@nichmor

nichmor commented Apr 11, 2024

Copy link
Copy Markdown
Contributor Author

LGTM as a quick fix. In general, we should make sure, though, that setup-pixi works out of the box if only a pyproject.toml is present without specifying manifest-path.

@nichmor can you bump the patch version in package.json? Then the release pipeline will be triggered automatically once merged.

Hey!
Yeah, totally. I just wanted to make the scope of this PR very small and later maybe work on automatic discovery of pyproject manifest.
Let me bump the patch version

@nichmor

nichmor commented Apr 11, 2024

Copy link
Copy Markdown
Contributor Author

bumped.
@pavelzw can I merge it?

@pavelzw

pavelzw commented Apr 11, 2024

Copy link
Copy Markdown
Collaborator

let's wait for CI and then we can merge it 👍🏻

@pavelzw pavelzw enabled auto-merge (squash) April 11, 2024 12:59
@pavelzw pavelzw disabled auto-merge April 11, 2024 13:28
@pavelzw pavelzw merged commit 4fc8d82 into main Apr 11, 2024
@pavelzw pavelzw deleted the fix/restoring-cache-with-pyproject-toml branch April 11, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants