Skip to content

Commit 1adea12

Browse files
authored
SelectPanel: add role=combobox to filter input (#4977)
* add role=combobox to filter input * Create selectpanel-combobox.md
1 parent c097e96 commit 1adea12

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

.changeset/green-poems-play.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@primer/react": patch
3+
---
4+
5+
SelectPanel: Add `role=combobox` to filter input (behind feature flag `primer_react_select_panel_with_modern_action_list`)

packages/react/src/FilteredActionList/FilteredActionListWithModernActionList.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,8 +138,11 @@ export function FilteredActionList({
138138
onChange={onInputChange}
139139
onKeyPress={onInputKeyPress}
140140
placeholder={placeholderText}
141-
aria-label={placeholderText}
141+
role="combobox"
142+
aria-expanded="true"
143+
aria-autocomplete="list"
142144
aria-controls={listId}
145+
aria-label={placeholderText}
143146
aria-describedby={inputDescriptionTextId}
144147
{...textInputProps}
145148
/>

0 commit comments

Comments
 (0)