Bug fix: ButtonBase sx base styles leaking into CSS modules feat flag (#5213)

langermank · web-flow · commit a5d7fe34a20c · 2024-11-01T23:17:50.000Z
* fix

* Create chilly-phones-explode.md
diff --git a/.changeset/chilly-phones-explode.md b/.changeset/chilly-phones-explode.md
@@ -0,0 +1,5 @@
+---
+"@primer/react": patch
+---
+
+Bug fix: `ButtonBase` sx base styles leaking into CSS modules feat flag
diff --git a/packages/react/src/Button/ButtonBase.tsx b/packages/react/src/Button/ButtonBase.tsx
@@ -118,7 +118,7 @@ const ButtonBase = forwardRef(
           >
             <Box
               as={Component}
-              sx={sxStyles}
+              sx={sxProp}
               aria-disabled={loading ? true : undefined}
               {...rest}
               ref={innerRef}

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"@primer/react": patch
 +---
++
 +Bug fix: `ButtonBase` sx base styles leaking into CSS modules feat flag
Original file line number	Diff line number	Diff line change
`@@ -118,7 +118,7 @@ const ButtonBase = forwardRef(`
`118`	`118`	`>`
`119`	`119`	`<Box`
`120`	`120`	`as={Component}`
`121`		`- sx={sxStyles}`
	`121`	`+ sx={sxProp}`
`122`	`122`	`aria-disabled={loading ? true : undefined}`
`123`	`123`	`{...rest}`
`124`	`124`	`ref={innerRef}`