Skip to content

mWeb(Safari) - Clicking on my stuff makes assets tab partially active #2682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PiyushChandra17 opened this issue Dec 4, 2023 · 3 comments
Assignees
Labels
Area: Mobile For issues affecting mobile or responsive behavior Bug Error or unexpected behaviors

Comments

@PiyushChandra17
Copy link
Contributor

p5.js version

2.9.3

What is your operating system?

None

Web browser and version

No response

Actual Behavior

mWeb(Safari) - Clicking on my stuff makes assets tab partially active

mweb

Expected Behavior

mWeb(Safari) - Clicking on my stuff should not make assets tab partially active

Steps to reproduce

Steps:

  1. Open the editor web app in mWeb (Safari)
  2. Tap on my stuff
  3. Notice verify assets tab becomes partially active while still on sketches
@PiyushChandra17 PiyushChandra17 added the Bug Error or unexpected behaviors label Dec 4, 2023
@PiyushChandra17
Copy link
Contributor Author

@lindapaiste I think the position of dropdown is causing the issue, perhaps it's should be a quick fix. Please let me know what do you think? Thanks!

@lindapaiste lindapaiste added the Area: Mobile For issues affecting mobile or responsive behavior label Dec 4, 2023
@lindapaiste
Copy link
Collaborator

Interesting. What you are describing as "partially active" seems to be the :hover/:focus style. We have the same style on both :hover and :focus so it could be either. I think you're right about the cause. I'm not sure about the best solution. I would read up on when and how the :hover and :focus states get applied on touch devices. I wonder if something like a pointer-events: all or a stopPropagtion() on the menu component would help by preventing the touch from bubbling through to the "Assets" tab.

Side note: I opened the editor on my phone to see the issue (I do see it) and I'm not able to click the sort icon. Is that just me? My phone is a 6S which is kind of ancient.

@PiyushChandra17
Copy link
Contributor Author

@lindapaiste I don't think device should be an issue. If you observe carefully then you'll notice that tapping on my stuff either "left" or "right" is working fine but if you tap on "centre" then assets tab gets focused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Mobile For issues affecting mobile or responsive behavior Bug Error or unexpected behaviors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants